Skip to content

Commit

Permalink
If the keychain does not provide valid credentials log out (#10417)
Browse files Browse the repository at this point in the history
Fixes: #10408
  • Loading branch information
TheOneRing authored Jan 25, 2023
1 parent e66ba4e commit 3eaea38
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
7 changes: 7 additions & 0 deletions changelog/unreleased/10408
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
Bugfix: Undefined client state after fetching credentials failed

We fixed a bug where the client got stuck in a "No connection configured" state if an
error occurred during the retrieval of the credentials from the system's keychain.
The client then required a manual log out and log in.

https://github.com/owncloud/client/issues/10408
3 changes: 3 additions & 0 deletions src/libsync/creds/httpcredentials.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,9 @@ void HttpCredentials::fetchFromKeychainHelper()
_ready = true;
emit fetched();
}
} else {
Q_EMIT authenticationFailed();
Q_EMIT _account->invalidCredentials();
}
});
}
Expand Down

0 comments on commit 3eaea38

Please sign in to comment.