Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle credentials not found in the keychain #10408

Closed
TheOneRing opened this issue Jan 18, 2023 · 2 comments · Fixed by #10417
Closed

Handle credentials not found in the keychain #10408

TheOneRing opened this issue Jan 18, 2023 · 2 comments · Fixed by #10417
Assignees
@TheOneRing
Labels
Needs info p2-high Escalation, on top of current planning, release blocker
Milestone
Desktop Client 4.0

Comments

@TheOneRing
Copy link
Contributor

When the client fails to look up the credentials in the keychain, log out out the account.

23-01-18 12:53:53:426 [ critical default ]:	ENSURE: "!data.isEmpty()" in file /private/var/folders/s_/29j5jn_972502zl0mp1m6n9h0000gn/T/drone-Ba59lUuiY8iOeJhc/drone/src/src/macos-64-clang/ownCloud-3.1.0-daily20230115.9784/src/libsync/creds/httpcredentials.cpp, line 221 auto OCC::HttpCredentials::fetchFromKeychainHelper()::(anonymous class)::operator()() const
@TheOneRing TheOneRing self-assigned this Jan 18, 2023
@TheOneRing TheOneRing added this to the 4.0 milestone Jan 18, 2023
@TheOneRing TheOneRing added the p2-high Escalation, on top of current planning, release blocker label Jan 18, 2023
TheOneRing added a commit that referenced this issue Jan 19, 2023
@TheOneRing
If the keychain does not provide valid credentials log out
faf9cbe 
Fixes: #10408
@TheOneRing TheOneRing mentioned this issue Jan 19, 2023
Merged
TheOneRing added a commit that referenced this issue Jan 25, 2023
@TheOneRing
If the keychain does not provide valid credentials log out (#10417)
3eaea38 
Fixes: #10408
TheOneRing added a commit that referenced this issue Feb 14, 2023
@TheOneRing
Fix #10408
f377086
TheOneRing added a commit that referenced this issue Feb 14, 2023
@TheOneRing
Fix #10408
5fad571
TheOneRing added a commit that referenced this issue Feb 14, 2023
@TheOneRing
Fix #10408
1cdcb88
@HanaGemela
Copy link
Contributor

@TheOneRing please provide steps to test

@TheOneRing
Copy link
Contributor Author

Hard to reproduce, was in part caused by us saving an empty password under certain conditions related to log out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
Needs info p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Milestone
Desktop Client 4.0
Development

Successfully merging a pull request may close this issue.

If the keychain does not provide valid credentials log out owncloud/client
3 participants
@TheOneRing @HanaGemela @saw-jan