Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync Icons in File Browser like Dropbox #102

Closed
Deltachaos opened this issue Nov 20, 2012 · 45 comments
Closed

Sync Icons in File Browser like Dropbox #102

Deltachaos opened this issue Nov 20, 2012 · 45 comments

Comments

@Deltachaos
Copy link

I would love to see Sync Icons for the Files like in Dropbox

@dragotin
Copy link
Contributor

Sorry, this is obviously not a dupe, reopen.

@dragotin dragotin reopened this Nov 20, 2012
@laryllian
Copy link

What file browser are you exactly talking about? Nautilus right? A plug-in would be needed, I guess...

@Deltachaos
Copy link
Author

I talk about Nautilus and the Windows Explorer

@hwinkel
Copy link

hwinkel commented Mar 17, 2013

Is there any progress on this. We are just replacing Dropbox with OC 5.0. at least on windows I can confirm that the OC synced folders have NO indication (Icon in Filebrowser) that they have a sync configuration at all, nor the status seems to be reported. As OC has the ability to sync any arbitrary folder it would be great to add the Icons as seen in DropBox and Box.com.

@danimo
Copy link
Contributor

danimo commented Mar 17, 2013

No progress on this yet, but it's on the roadmap.

@donty
Copy link

donty commented Jul 10, 2013

This would be a great visual re-assurance to users that things are working and everything is sync'd. Look forward to it now it is on the roadmap. Thanks

@siewertw
Copy link

I just installed OC and this was the one thing that could be improved! Looking forward to it!

@maddhin
Copy link

maddhin commented Jul 14, 2013

I don't want to open an new issue but it would be good to have "file placeholders" in explorer, etc. I.e. one can see all files that will be synced. This might be the same as dropbox and a 'sync icon' but not necessarily. owncloud should indicate the files it will sync - ideally with a fancy status icon:)

@scalcerano
Copy link

I wrote a small ms explorer extension to put icon overlay status on each file.
It works only on 64bit windows.
http://www.vertigoconsulting.it/downloads/OwncloudIconAddon.zip
It's a trick until this feature will be added to the owncloud client.

@jancborchardt
Copy link
Member

I’d like to schedule this for 1.5 because it’s very important feedback. @danimo @dragotin what do you think?

@karlitschek
Copy link

@jancborchardt This is an complex issue. We still need planing how to do that.

@jancborchardt
Copy link
Member

Yeah, I understand. I just want to make clear that interface-wise, this is the number 1 priority.

@jancborchardt
Copy link
Member

Let me rephrase that »in my opinion, and only regarding the interface, this is very important«. What do you think @MTRichards?

I know it’s a big task etc. but currently users can never be sure if a specific file is up to date. You have to dig into the settings to find out. Especially if you sync custom folders it’s really difficult. And that is one of the 2 basic things a »sync client« should do: 1) sync and 2) give feedback on the sync state.

@MTRichards
Copy link

Totally agree. Sync overlay icons are very important.

@MTRichards
Copy link

I would like to see this in 1.5, so made that a milestone. Lets discuss this weekend.

@BenS89
Copy link

BenS89 commented Aug 21, 2013

Maybe this feature could be implemented for OSX >= 10.6 with class NSWorkspace (see setIcon:forFile:options) or with NSDockTile. For Windows, IShellIconOverlayIdentifier interface could be interesting. I´m also looking forward about seeing this feature as soon as possible. In my opition, this is one of the most important features because user always need interaction with the used application.

@scalcerano
Copy link

For windows, I would like to contribute to develop interface, but I need to have some additional information (which dev tools you are using now, SO, ecc...).
I use visual studio 2012 and I don't think you are using the same platform.

@ubiquitas
Copy link

bring it on - much needed. Nice work with your workaround scalcerano :)

@BenS89
Copy link

BenS89 commented Sep 28, 2013

Is there any progress? In my opinion this feature should have the highest priority.

@danimo
Copy link
Contributor

danimo commented Sep 28, 2013

@BenS89 As indicated in this issue summary, resolving this issue is scheduled for the next major release, 1.5. That one even has an estimated arrival date associated with it. If you're not planning to obey the "if you think its urgent, help implementing it"-rule of Open Source applications, make at least some effort to check the facts.

@BenS89
Copy link

BenS89 commented Sep 28, 2013

Thank you for your friendly reply! I just gave some hints on how to implement this feature for Windows and MacOS! The short answer "in progress" or "he have an idea on how to implement it" would have been enough!

@danimo
Copy link
Contributor

danimo commented Sep 28, 2013

@BenS89 Sorry, didn't see your comments above. Lately lots of people complain without contributing, which is quite frustrating. You've obviously offered help. Anyway, the implementation of Windows should be fairly straight forward. On OS X, the information I have is that there is no official API that exactly does the Job, which is why Dropbox & al hack their way into finder.

@danimo
Copy link
Contributor

danimo commented Sep 28, 2013

@BenS89 More information: I have backported the API which will provide the information (a socket that the owncloud API provides) in master. It needs to be hooked up to the sync db, which will probably happen next week.

@danimo
Copy link
Contributor

danimo commented Sep 28, 2013

@BenS89 As for Windows, I think we should just go with Visual Studio for development, Eventually we may be able to use MinGW (which we use for the client as well), but given that we are dealing with COM, that's an unnecessary complication for the first step.

@BenS89
Copy link

BenS89 commented Sep 28, 2013

I can confirm this. MacOS X > 10.6 do not allow to access the finder api. That is why dropbox et al use code injection to solve this issue. It is not elegant, but it works. For windows, I do agree that you have to deal with COM and write a overlay handler. But your posts show that there is some progress =)

@danimo
Copy link
Contributor

danimo commented Sep 28, 2013

@BenS89 Yes, we sometimes to a bad job documenting out trains of thought here :/

@BenS89
Copy link

BenS89 commented Sep 28, 2013

Just two ideas concerning the OSX implementation:

1.) Look into Wolf Rentzsch's mach_inject (https://github.com/rentzsch/mach_inject) to be able to inject a custom bundle to a Cocoa application.

2.) class NSWorkspace (see setIcon:forFile:options)

Basic idea:

1.) Try to get preview of file with QLThumbnailImageCreate (if not NULL you will get thumbnail icon)

2.) If you didn't get thumbnail, then get default OS X icon for file (NSWorkspace iconForFile)

3.) Combine thumbnail (or default icon) with your badge

4.) Set new icon to the file (NSWorkspace setIcon:forFile:options)

@freeman42x
Copy link

👍

@krusche
Copy link

krusche commented Jan 28, 2014

Any news on this issue? In 1.5 for Mac OS there are no icon overlays yet. Would be really nice to see this feature soon!

@jancborchardt
Copy link
Member

The milestone is set to »1.7 – UI Enhancements« which is »Due in 4 months«.

@emmanuel099
Copy link

Hello ownCloud devs,
I'm a KDE/Dolphin developer and I'm really interested in an ownCloud plugin for Dolphin.

What are your plans for the API?
Socket based and/or D-Bus based?

Possible problems in the current Socket API:
In my opinion the protocol shouldn't use ':' as parameter seperator, because folder/file names can have colons too. Maybe '\t' would be better.
Also multiple messages should be joined by smth. like newline '\n' to make the parsing on the client side easier. (see SocketApi::command_RETRIEVE_FOLDER_STATUS for example)
At the end of every "remote procedure call" should be smth. like "ok", "done" or "finished" to mark the end of the whole message.

Feel free to ping me if I can help with the implementation ;)

@dragotin
Copy link
Contributor

Hi @emmanuel099, of course your help would be really appreciated!

Regarding the API, we're not yet settled. We started with a socket based api because all we are doing has to be cross platform compatible (Linux, Mac and Windows). Your suggestions about the protocol sound pretty decent to me. Can we use a pipe char as a delimiter, as that is a not allowed char for file names? So yes, if you have concrete suggestions or patches for the API, just send it over.

Great stuff, thanks !

@ottok
Copy link

ottok commented Mar 5, 2014

👍

@MTRichards
Copy link

Making a note on this item in particular - thinking about oC 7.

Sync overlay icons (that indicate file and folder sync status) in the desktop client are critical when we get rid of the shared folder. We can't remove the shared folder on the server without providing a visual display of whether the folders on the desktop (and, to be honest, on the server too) are shared with the user, by the user or are just plan old files the user owns - and their status syncing with the server.

Just making sure we catch this. :)

@dragotin @danimo @karlitschek @ogoffart @woboq

@danimo
Copy link
Contributor

danimo commented Apr 17, 2014

@MTRichards This depends on the server telling us whether a folder will be shared. Do we have that in OC7?

@MTRichards
Copy link

I sure hope so, because if we don't we can't remove the shared folder!

@danimo
Copy link
Contributor

danimo commented Apr 17, 2014

@MTRichards I mean we need signalling as a WebDAV property.

@MTRichards
Copy link

I get that, and we can't be removing the "Shared" folder without it! How would you know what you are looking at on your desktop? What a mess!

@danimo
Copy link
Contributor

danimo commented Apr 17, 2014

@karlitschek ?

@karlitschek
Copy link

@danimo The plan is that ownCloud 7 signals that as webdav property. Exactly as you said.
Do you have an idea how this property can be called?
Perhaps related to the read only flag?

@karlitschek
Copy link

@schiesbn fyi

@DeepDiver1975
Copy link
Member

I did some research on dav properties some time ago.

I will submit a pull request. 

Tom

Von Samsung Mobile gesendet

-------- Ursprüngliche Nachricht --------
Von: Frank Karlitschek notifications@github.com
Datum:17.04.2014 23:50 (GMT+01:00)
An: owncloud/mirall mirall@noreply.github.com
Betreff: Re: [mirall] Sync Icons in File Browser like Dropbox (#102)

@danimo The plan is that ownCloud 7 signals that as webdav property. Exactly as you said.
Do you have an idea how this property can be called?
Perhaps related to the read only flag?


Reply to this email directly or view it on GitHub.

@jancborchardt
Copy link
Member

Yup, good call on that @MTRichards. Shared files and folders should also have an overlay similar to the sync status.

@simonjwoolf
Copy link

Just adding a +1 for this feature. We're doing a corporate migration from Dropbox to Owncloud and this is the only really major omission.

Not having any feedback in the file browser, as to whether a file or folder is a) synced or b) up to date is a serious drawback.

Clearly this feature would need to be available in Mac, Win and Linux environments

@dragotin
Copy link
Contributor

dragotin commented Jul 4, 2014

closing. Please track in #1818

@dragotin dragotin closed this as completed Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests