Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow redirect on direct download link #2614

Closed
DeepDiver1975 opened this issue Dec 15, 2014 · 12 comments
Closed

allow redirect on direct download link #2614

DeepDiver1975 opened this issue Dec 15, 2014 · 12 comments
Milestone
1.8 - UI Enhancem...

Comments

@DeepDiver1975
Copy link
Member

refs owncloud/core#12286 (comment)

@guruz @dragotin @danimo @ogoffart
@guruz guruz added this to the 1.8 - UI Enhancements milestone Dec 15, 2014
@guruz guruz added the Feature label Dec 15, 2014
ogoffart added a commit that referenced this issue Dec 16, 2014
@ogoffart
network jobs: Refactor the redirect handling in AbdtractNetworkJob
3ee1416 
Move the redirect handling from CheckServerJob to AbstractNetworkJob, so we can
later use it in any job  (in preparation for task #2614)
ogoffart added a commit that referenced this issue Dec 16, 2014
@ogoffart
Download job: allow redirect on direct download link
b1d392e 
Issue #2614
@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Dec 16, 2014
@ogoffart
Copy link
Contributor

I did not personaly test the feature yet. But the owncloud client 1.7.x will not work if there is a redirect, only the owncloud client 1.8 will.

@DeepDiver1975
Copy link
Member Author

I did not personaly test the feature yet. But the owncloud client 1.7.x will not work if there is a redirect, only the owncloud client 1.8 will.

fine enough - what is the behavior if the direct download fails (for whatever reason)? Do you already fallback to regular download via webdav from owncloud?

@ogoffart
Copy link
Contributor

No, we don't do that.

@DeepDiver1975
Copy link
Member Author

No, we don't do that.

need a new ticket? 🙊

@guruz
Copy link
Contributor

guruz commented Dec 16, 2014

@DeepDiver1975 two things to consider:

  • If the directDownloadURL doesn't work, why would it work through the oC instance? (yes I know, firewalls etc.. but then why would the admin have it enabled in the first place?)
  • What if the oC instance is provisioned quite low (hardware specs) and then all clients occupy the server connection slots with downloads?

@DeepDiver1975
Copy link
Member Author

If the directDownloadURL doesn't work, why would it work through the oC instance? (yes I know, firewalls etc.. but then why would the admin have it enabled in the first place?)

please consider the fact that you will get:

  • unknown protocol handlers
  • clients on different network segments can simply have access or not - especially on laptops this is a moving tagret

@DeepDiver1975
Copy link
Member Author

What if the oC instance is provisioned quite low (hardware specs) and then all clients occupy the server connection slots with downloads?

Deployment issue - nothing we have to think about. Direct download is to be seen as an option to

  • download file content faster
  • reduce the server load

Due to whatever reason: if the dd fails we have to fall back

@guruz guruz mentioned this issue Dec 17, 2014
Closed
@DeepDiver1975 DeepDiver1975 mentioned this issue Jan 7, 2015
Closed
3 tasks
@luciamaestro luciamaestro removed the ReadyToTest QA, please validate the fix/enhancement label Jan 8, 2015
@luciamaestro
Copy link

It couldn't be tested from the client so I close it.

@DeepDiver1975 DeepDiver1975 reopened this Jan 9, 2015
@DeepDiver1975
Copy link
Member Author

I'm reopening as I think this is not yet done:

  • change to different webdav propery name
  • failover in case direct download fails

@guruz @ogoffart

@ogoffart
Copy link
Contributor

ogoffart commented Jan 9, 2015

Failover should already work.
What are the new webdav names?

@DeepDiver1975
Copy link
Member Author

What are the new webdav names?

the one you propoesed 🙊 ... let me check ...

@DeepDiver1975
Copy link
Member Author

@ogoffart owncloud/core#12854 (comment)

ogoffart added a commit that referenced this issue Jan 15, 2015
@ogoffart
csync propfind: Rename the directDownload property
e31514f 
The owncloud server has a different name because if it was named the same
it would break the 1.7 client

Issue #2614
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8 - UI Enhancements
Development

No branches or pull requests
4 participants
@ogoffart @guruz @DeepDiver1975 @luciamaestro