Adding foundation for the direct download url #12854
Conversation
|
looks good 👍 |
| * For now the returned array can hold the parameter url - in future more attributes might follow. | ||
| * | ||
| * @param string $path | ||
| * @return []|null |
There was a problem hiding this comment.
For return type you still need array instead of [] afaik
There was a problem hiding this comment.
Maybe return an empty array instead of null when not supported?
DeepDiver1975
force-pushed
the
add-direct-download-link
branch
from
ac0f047
to
4c7cdbd
Compare
| * @return array | ||
| */ | ||
| public function getDirectDownload($path) { | ||
| // FIXME: we need a global mount config which enables/disables direct download links |
There was a problem hiding this comment.
@icewind1991 yet another mount config option - what is the plan to incorporate this? THX
There was a problem hiding this comment.
Why would there be a config for this? shouldn't the backend have enough info to determine if it can be used?
There was a problem hiding this comment.
Why would there be a config for this? shouldn't the backend have enough info to determine if it can be used?
we want to give the admin to explicitly enable/disable direct download on mount level.
DeepDiver1975
force-pushed
the
add-direct-download-link
branch
from
58f37d9
to
661726c
Compare
|
@owncloud-bot retest this please |
|
Refer to this link for build results (access rights to CI server needed): |
|
ping. can anyone have a look? |
|
Code looks good, but currently it doesn't do anything useful, or do I miss something? The only implementation of getDirectDownload() returns a empty array. What about the open point "rename dav property to avoid unexpected behavior of client 1.7.x series"? @DeepDiver1975 Is this PR complete? Any steps to try it? |
|
I guess this requires an implementation in a storage backend. |
danimo
changed the title
|
Be explicit? "downloadURL" |
DeepDiver1975
force-pushed
the
add-direct-download-link
branch
from
661726c
to
d5657ac
Compare
|
Refer to this link for build results (access rights to CI server needed): |
DeepDiver1975
force-pushed
the
add-direct-download-link
branch
from
d5657ac
to
81243b0
Compare
|
The inspection completed: 3 new issues, 5 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 |
|
cool. Let´s merge. |
Adding foundation for the direct download url
refs #12286
@dragotin @danimo @guruz @ogoffart @karlitschek @icewind1991 THX