Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSL] [Client certs] Actually display/parse HTML error message #2799

Closed
guruz opened this issue Feb 8, 2015 · 3 comments
Closed

[SSL] [Client certs] Actually display/parse HTML error message #2799

guruz opened this issue Feb 8, 2015 · 3 comments
Assignees
Milestone

Comments

@guruz
Copy link
Contributor

guruz commented Feb 8, 2015

Seen this when testing #69 some days ago. Might not be that important anymore since I think we show a dialog now in any case?

02-04 17:50:18:182 0x7fabfae05610 networkjobs.cpp:543 error: status.php replied  400 "<html>
<head><title>400 No required SSL certificate was sent</title></head>
<body bgcolor="white">
<center><h1>400 Bad Request</h1></center>
<center>No required SSL certificate was sent</center>
<hr><center>nginx</center>
</body>
</html>
@guruz guruz added this to the 1.8.1 - Bugfix milestone Feb 8, 2015
@jdhoek
Copy link
Contributor

jdhoek commented Feb 8, 2015

Yes, a dialog is shown when any https URL returns any error (at least, in the initial connection wizard).

Parsing the actual error message might be complicated if HTML is returned (how will you display it?), but perhaps it is sufficient to settle for the HTTP error code?

For example, when a 403 code is returned, add the canonical description for it in the error message presented to the user:

Could not connect to https://owncloud.example.org/, the server said 403: Forbidden.

That would at least tell the user something of the nature of the error.

@guruz
Copy link
Contributor Author

guruz commented Feb 8, 2015

@ogoffart would probably recommend to use a simple QRegExp to take everything in the body that is not a <tag> (or </tag>)

@ogoffart ogoffart modified the milestones: 1.9 - Multi-account, 1.8.1 - Bugfix Apr 8, 2015
@guruz guruz modified the milestones: 2.1-next, 2.0 - Multi-account Jun 24, 2015
@guruz guruz modified the milestones: 2.2-next, 2.1-next Nov 3, 2015
@guruz guruz removed this from the 2.2.0-current milestone Feb 23, 2016
@guruz guruz added this to the 2.3.0 milestone Oct 19, 2016
guruz added a commit that referenced this issue Oct 19, 2016

Unverified

No user is associated with the committer email.
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.
@guruz
Copy link
Contributor Author

guruz commented Oct 19, 2016

PR is pending..

@guruz guruz closed this as completed Oct 19, 2016
guruz added a commit that referenced this issue Nov 23, 2016

Verified

This commit was signed with the committer’s verified signature.
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.
guruz added a commit that referenced this issue Nov 23, 2016

Verified

This commit was signed with the committer’s verified signature.
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants