Wizard: Show if server asks for client certificate #2799 #69 #5261
+30
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ogoffart Please re-evaluate. I extract the message now early so reply is not deleted before. |
ogoffart
reviewed
Nov 23, 2016
| @@ -447,7 +447,7 @@ bool CheckServerJob::finished() | |||
| } | |||
|
|
|||
| bool success = false; | |||
| QByteArray body = reply()->readAll(); | |||
| QByteArray body = reply()->peek(1024); | |||
There was a problem hiding this comment.
1024 bytes should be enough for every status.php replies?
There was a problem hiding this comment.
Not sure. Right now we're at around 110 bytes. Shall I increase it or not?
No need to mess with the old wizard logic until @danimo has given us his code for the new wizard. |
This also nicely displays the 'Untrusted domain' message of oC. The link to add a trusted domain (via web browser) is clickable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also nicely displays the 'Untrusted domain' message of oC.
The link to add a trusted domain (via web browser) is clickable.