[Windows, OS X] Switch to Qt 5.6.2 for 2.3 client

[guruz]

Right now we're based on 5.4.0+patches

https://github.com/qtproject/qtbase/blob/dev/dist/changes-5.4.1 (incomplete usually)
https://github.com/qtproject/qtbase/blob/dev/dist/changes-5.4.2 (incomplete usually)
https://github.com/qtproject/qtbase/blob/dev/dist/changes-5.5.0 (incomplete usually)
https://wiki.qt.io/New_Features_in_Qt_5.5

[dragotin]

I'd vote for staying with the current build that we had for 1.8.4 (5.4.0+patches) for 2.0.0 and go to hopefully 5.5.1 wtih the next bugfix release, ie. oCC 2.0.1. One moving target less.

[hefee]

for downstream it would be nice to to nail to newest qt version and don't bump the minimum version for no reason.

And changing the minimum version within bugfix releases is really not a good thing, cause normally bugfix releases should be a minimal changeset and therefore the dependency shouldn't changed.

For sure you can ship a new qt version within obs at any time - i'm just talking about the CMakefile.txt

[danimo]

There is no time for a 5.5 switch in the 2.0 timeframe. @hefee I don't think we'll soon drop support for older Qt versions, but e.g. 5.5. solves the systray issue. But that's a different conversation, since we can't have 5.5. everywhere in the forseeable future.

[guruz]

-> 2.1 then

[guruz]

5.5.1 is about-to-be-released..

[ogoffart]

5.5.1 was released

[dragotin]

This is the repo to update: https://build.opensuse.org/project/show/isv:ownCloud:toolchains:mingw:win32:stable
and this is how its done:
https://en.opensuse.org/openSUSE:Build_Service_Collaboration#How_do_I_contribute_my_changes_to_someone_else_packages.3F

[guruz]

5.6 (unreleased) has some network fixes, analyzing those now and then maybe we stay a bit on our patched 5.4 plus those patches..

[scolebrook]

Is the patched version of qt you use for official builds of ownCloud available anywhere? Or are the mentioned patches in the client repo and get applied during the build process?

I'd prefer to make sure that our build is as close as possible to being the same as yours (apart from branding of course).

[ogoffart]

@scolebrook We use the Qt build on OBS. All the patches are already upstreamed.
https://build.opensuse.org/package/show/isv:ownCloud:toolchains:mingw:win32:stable/mingw32-libqt5-qtbase

[guruz]

@scolebrook With ownBrander you automatically get the correct Qt https://doc.owncloud.org/server/8.1/admin_manual/enterprise_clients/creating_branded_apps.html

[scolebrook]

@ogoffart So the patches discussed relate to win only? Stock qt for mac builds is fine?

@guruz We evaluated ownbrander back when it was first released. It didn't do a number of key things we needed and we had a conference call with @bboule, @gig13 and @MTRichards about it IRC. That was a while ago and I should probably re-evaluate as I believe there have been some improvements.

[guruz]

@danimo @dschmidt @dragotin FYI 0070835

[guruz]

@scolebrook We use the same Qt-patches-on-top for OS X and Windows builds

[dschmidt]

@guruz interesting. Thanks!

[dschmidt]

Any other thoughts on Qt 5.6? Wondering if it's worth trying to build it soon...

[guruz]

It looks like I need also

diff --git a/admin/osx/macdeployqt.py b/admin/osx/macdeployqt.py
index 60ff4b9..3a39d82 100755
--- a/admin/osx/macdeployqt.py
+++ b/admin/osx/macdeployqt.py
@@ -38,8 +38,10 @@ QT_PLUGINS = [
     'imageformats/libqgif.dylib',
     'imageformats/libqico.dylib',
     'imageformats/libqjpeg.dylib',
     'imageformats/libqsvg.dylib',
     'imageformats/libqmng.dylib',
+    'bearer/libqcorewlanbearer.dylib',
+    'bearer/libqgenericbearer.dylib'
 ]

 QT_PLUGINS_SEARCH_PATH=[

else I get "Network access is disabled". Although this is odd, I thought if the bearer plugins are not loaded it would just allow me to use the network no matter what.. (since that is what happened when using Qt 5.4.. or maybe my 5.4 was compiled without bearer management?)

FYI @lpotter

[guruz]

Win32: Work is ongoing in https://build.opensuse.org/project/monitor/isv:ownCloud:toolchains:mingw:win32:2.3

[guruz]

@jturcotte yesterday volunteered to look at the macbuilder/lexmacbuilder work to be done including jenkins integrations and making sure nothing break :)

I'll try to pick up the Windows part and switch from 5.6.1 to 5.6.2 (will ping @dragotin @jnweiger if i need help)

[guruz]

We have a Windows build! Thanks a lot @dragotin and @dschmidt

https://rotor.int.owncloud.com/view/ownCloud-client/job/ownCloud-client-win32/6619/
@SamuAlfageme Can you give this a smoke test? It should mention

Docker image: guruz/docker-owncloud-client-win32 from docker build https://github.com/guruz/docker-ownCloud-client-win32.git#2.3

client branch: win_562 (would need to be merged when changing Jenkins)

@jnweiger Do you want to tag this as real docker-owncloud-client-win32 ? You need to adapt the Jenkins configuration to check if it will really take the tagged docker-owncloud-client-win32 then for 2.3
The goal would be to have the Windows nightlies build with 5.6.2

@dschmidt will work on improving the currently a bit hacky 2.3 OBS repo. Possibly even considering #2140 ?

(I'm gone until 12th this month)

[guruz]

macOS

• 10.11.5 the 2.3 nightly is using Qt 5.6.2 and works

Windows

• Windows 10 the 2.3 nightly is using Qt 5.6.2 and works

Maybe @SamuAlfageme has input on older Windows like Windows 7?

[SamuAlfageme]

@guruz I have been actually using the build from the new cross-compilation image for over a week now in all my tests in Win(7), so far, so good.

Sometime this week, I would move to carry a full functionality/regression test of these builds.

[dschmidt]

Woohoo, that's good news that we have no obvious regressions :)
(We did a big jump in compiler versions e.g.)

[guruz]

Closing this as we implicitely test this :)