Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Owncloud context menu options differ when file has not been synced yet #7330

Closed
HanaGemela opened this issue Jul 19, 2019 · 6 comments
Closed
Assignees
Labels
p3-medium Normal priority
Milestone

Comments

@HanaGemela
Copy link
Contributor

Client: 2.6.0alpha2 (build 12128)
macOS: 10.14.5
Server: 10.2.1 (stable)

Steps to recreate:

  1. Create a new file
  2. Quickly open the ownCloud context menu by right clicking on the file before it gets synced

Actual result: Delete and Move and Upload options are available but once the file is synced they disappear. Is there any reason why the option to delete or move is dependant on the state of the file if it has been synced or not?

Expected result: Not really sure. Should the options be always available or are they displayed by mistake?

image

@HanaGemela HanaGemela added the p3-medium Normal priority label Jul 19, 2019
@HanaGemela HanaGemela added this to the 2.6.1 milestone Jul 19, 2019
@jnweiger
Copy link
Contributor

jnweiger commented Jul 19, 2019

The menu entry 'Move and upload...' also appears in some other possibly unwanted situations:

Misfeature: this should not happen, imho

Scenario: Readonly folder excluded from selective sync receives a new file locally
  GIVEN folder "foobar" was fully synced 
  AND user changes the folder to readonly e.g. via `chmod a-w foobar`
  AND user disables the folder via selective sync. 
  WHEN root user creates a file "foobar/newfile.txt"
  THEN a yellow exclamation mark overlay icon is shown on that file
  AND the ownCloud context menu has an extra entry "Move and upload..."

@ogoffart
Copy link
Contributor

PR: #7527

@ogoffart
Copy link
Contributor

The PR should remove these menu entry, that were there by mistake as the code thought this was a read-only folder while it wasn't

@ogoffart ogoffart added ReadyToTest QA, please validate the fix/enhancement and removed PR available labels Nov 18, 2019
@HanaGemela
Copy link
Contributor Author

Fixed in 2.6.1-daily20191127 (build 12791), macOS 10.15.1
Still broken in 2.6.1daily20191127 (build 12732), Windows 10

@HanaGemela HanaGemela removed the ReadyToTest QA, please validate the fix/enhancement label Nov 28, 2019
@michaelstingl michaelstingl modified the milestones: 2.6.1, 2.6.2 Dec 2, 2019
@HanaGemela
Copy link
Contributor Author

Fixed in 2.6.1sprint2 (build 12978), macOS 10.15.2

@HanaGemela HanaGemela modified the milestones: 2.6.2, 2.6.1 Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-medium Normal priority
Projects
None yet
Development

No branches or pull requests

4 participants