Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SocketApi: Don't assume read-only folder when permissions are not known #7527

Merged
merged 1 commit into from
Nov 18, 2019
Merged

SocketApi: Don't assume read-only folder when permissions are not known #7527

merged 1 commit into from
Nov 18, 2019

Conversation

ogoffart
Copy link
Contributor

Issue #7330

@ogoffart ogoffart requested a review from guruz October 15, 2019 14:17
@ogoffart ogoffart mentioned this pull request Oct 15, 2019
Closed
@mmattel
Copy link
Contributor

mmattel commented Nov 12, 2019

No reviewer?

@ogoffart
Copy link
Contributor Author

@guruz ping

TheOneRing
TheOneRing approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@ogoffart ogoffart merged commit d4e7c6b into 2.6 Nov 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-7330 branch November 18, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheOneRing TheOneRing TheOneRing approved these changes

@guruz guruz Awaiting requested review from guruz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ogoffart @mmattel @TheOneRing