Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when closing VFS dialog #7709

Closed
HanaGemela opened this issue Jan 31, 2020 · 2 comments
Closed

Crash when closing VFS dialog #7709

HanaGemela opened this issue Jan 31, 2020 · 2 comments
Assignees
@TheOneRing
Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug

Comments

@HanaGemela
Copy link
Contributor

Windows 10
macOS 10.15.2
client: 2.6.1
server: 10.3.2

Windows crash reports: 40872c65-1a69-4c45-ab06-bc9dfdf2bb16 and 0f4afa5e-513d-425e-9884-d10dbefbba87
macOS: f40ed3d8-51fa-47a2-9207-782d3d988e7f

Steps to recreate:

  1. Open Setting dialog -> go to Account tab
  2. Click 'Add new' from the Account dropdown
  3. Enter Server address
  4. Click Next
  5. Enter credentials
  6. Click Next
  7. Select virtual files and ignore the dialog to confirm
  8. Click Connect without closing the VFS dialog
  9. Close the VFS dialog by clicking on the Cross icon

Actual result: Crash
Expected result: Clicking Connect in the step 8 not allowed until VFS dialog is gone
@HanaGemela HanaGemela added type:bug p3-medium Normal priority feature:vfs native virtual files and placeholder implementation labels Jan 31, 2020
@jnweiger
Copy link
Contributor

jnweiger commented Jan 31, 2020 •
edited
Loading

"Don't press buttons in an unexpected order!" :-)
I assume, this is no new bug. It's been lurking there for ages, right?

TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
6617b33 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
241d60f 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
90d7a7e 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
3fee8d2 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
5770135 
Calling the callback after the receiver was deleted caused a crash
Fixes: #7709
Fixes: #7711
@michaelstingl
Copy link
Contributor

fixed

@TheOneRing TheOneRing mentioned this issue Apr 7, 2020
Closed
47 tasks
@HanaGemela HanaGemela mentioned this issue Apr 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TheOneRing @michaelstingl @jnweiger @HanaGemela