Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VFS dialog can be opened multiple times #7711

Closed
HanaGemela opened this issue Jan 31, 2020 · 1 comment
Closed

VFS dialog can be opened multiple times #7711

HanaGemela opened this issue Jan 31, 2020 · 1 comment
Assignees
@TheOneRing
Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug

Comments

@HanaGemela
Copy link
Contributor

Windows 10
macOS 10.15.2
client: 2.6.1

Steps to recreate:

  1. Click Enable VFS twice

Actual result: Two dialogs have been opened to confirm if VFS should be turned on. It is very confusing what should happen if user selects 'Stay safe' in one and enables VFS in the second one
Expected result: Only one dialog can be opened
@HanaGemela HanaGemela added type:bug p3-medium Normal priority feature:vfs native virtual files and placeholder implementation labels Jan 31, 2020
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 3, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
241d60f 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
90d7a7e 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit to TheOneRing/client that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
3fee8d2 
Calling the callback after the receiver was deleted caused a crash
Fixes: owncloud#7709
Fixes: owncloud#7711
TheOneRing added a commit that referenced this issue Feb 11, 2020
@TheOneRing
[Wizard] Make vfs dialog blocking
5770135 
Calling the callback after the receiver was deleted caused a crash
Fixes: #7709
Fixes: #7711
@michaelstingl
Copy link
Contributor

fixed

@TheOneRing TheOneRing mentioned this issue Apr 7, 2020
Closed
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheOneRing TheOneRing

Labels
feature:vfs native virtual files and placeholder implementation p3-medium Normal priority type:bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TheOneRing @michaelstingl @HanaGemela