Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ask user in dialog to restart app after update finished #11201

Merged
merged 2 commits into from
Nov 15, 2023
Merged

Ask user in dialog to restart app after update finished #11201

merged 2 commits into from
Nov 15, 2023

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented Sep 12, 2023 •
edited by TheOneRing
Loading

Fixes: #11132.

@fmoc fmoc requested a review from a team September 12, 2023 09:21
@TheOneRing TheOneRing added this to the Desktop 6.0 milestone Sep 12, 2023
TheOneRing
TheOneRing suggested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are in string freeze please target master

@fmoc fmoc changed the base branch from 5 to master September 12, 2023 09:40
@fmoc
Copy link
Contributor Author

fmoc commented Sep 12, 2023

Good point, thanks. The change is planned for 6.x+ anyway.

@fmoc fmoc requested a review from TheOneRing September 12, 2023 14:02
@CLAassistant
Copy link

CLAassistant commented Sep 16, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

erikjv
erikjv previously requested changes Sep 19, 2023
View reviewed changes
src/gui/updater/updatefinisheddialog.ui Outdated Show resolved Hide resolved
@fmoc fmoc force-pushed the work/updatefinisheddialog branch from e2bf5c7 to 9f7ee69 Compare November 8, 2023 11:46
TheOneRing
TheOneRing suggested changes Nov 8, 2023
View reviewed changes
src/gui/application.cpp Show resolved Hide resolved
src/gui/updater/ocupdater.cpp Show resolved Hide resolved
src/gui/updater/ocupdater.cpp Outdated Show resolved Hide resolved
src/gui/updater/updatefinisheddialog.ui Outdated Show resolved Hide resolved
@fmoc fmoc requested a review from michaelstingl November 9, 2023 11:11
@fmoc fmoc force-pushed the work/updatefinisheddialog branch from 9f7ee69 to f85e66a Compare November 9, 2023 15:46
@fmoc fmoc requested review from TheOneRing and erikjv November 9, 2023 17:02
@fmoc fmoc force-pushed the work/updatefinisheddialog branch from f85e66a to e442198 Compare November 15, 2023 11:11
@TheOneRing TheOneRing enabled auto-merge (rebase) November 15, 2023 12:29
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheOneRing TheOneRing merged commit de2533d into master Nov 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the work/updatefinisheddialog branch November 15, 2023 13:34
@fmoc fmoc mentioned this pull request Nov 16, 2023
Closed
2 tasks
fmoc pushed a commit that referenced this pull request Dec 15, 2023
Provide "restart required" dialog on Windows, too
b1cdbae 
This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
@fmoc fmoc mentioned this pull request Dec 15, 2023
Merged
fmoc pushed a commit that referenced this pull request Jan 17, 2024
Provide "restart required" dialog on Windows, too
fd7d80b 
This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
TheOneRing pushed a commit that referenced this pull request Jan 17, 2024
@TheOneRing
Provide "restart required" dialog on Windows, too
8eed583 
This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EParzefall EParzefall EParzefall left review comments

@tbsbdr tbsbdr tbsbdr left review comments

@TheOneRing TheOneRing TheOneRing approved these changes

@michaelstingl michaelstingl Awaiting requested review from michaelstingl

@erikjv erikjv Awaiting requested review from erikjv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Desktop 6.0
Development

Successfully merging this pull request may close these issues.

[QA] 5.0 client doesn't suggest restarting after upgrade on Ubuntu
7 participants
@fmoc @CLAassistant @erikjv @TheOneRing @michaelstingl @EParzefall @tbsbdr