Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide "restart required" dialog on Windows, too #11442

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

fmoc
Copy link
Contributor

@fmoc fmoc commented Dec 15, 2023

This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.

Fixes #10980.

screenshot_2023-12-15_16-07-41

screenshot_2023-12-15_18-05-15

@fmoc fmoc requested a review from a team December 15, 2023 17:25
Copy link
Contributor

@TheOneRing TheOneRing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can remember, the current message also allowed a user to decline an update.
So we need Skip update, Restart and update, Update later

@TheOneRing
Copy link
Contributor

Also please add a changelog entry

@fmoc
Copy link
Contributor Author

fmoc commented Jan 17, 2024

As far as I can remember, the current message also allowed a user to decline an update.
So we need Skip update, Restart and update, Update later

There are a "no URL dialog" and an error dialog in the NSIS updater class that offers these options but isn't regularly shown apparently. This dialog is shown when the update has been downloaded sucessfully already.

We need to think about consolidating all these (partially redundant) dialogs. However, this is outside of this PR's scope, which replaces a specific systray message with a dialog.

This commit provides a remodeled version of the "Update finished" dialog implemented in #11201.
@fmoc fmoc force-pushed the work/updatedownloadeddialog branch from b1cdbae to fd7d80b Compare January 17, 2024 11:47
@TheOneRing
Copy link
Contributor

image
your right

@TheOneRing TheOneRing self-requested a review January 17, 2024 12:58
@TheOneRing TheOneRing merged commit 8eed583 into master Jan 17, 2024
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the work/updatedownloadeddialog branch January 17, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend "restart required" dialog to Windows
2 participants