Merge pull request #37148 from owncloud/fix-exit-code

Add non-zero exit code for non-writable config dir and missing app-di…

changelog/unreleased/37148

@@ -0,0 +1,7 @@
+Bugfix: Fix CLI zero exit code on startup errors
+
+Zero exit code was returned on startup with a missing app directory
+or a non-writable config directory. Now exit code is 1.
+
+https://github.com/owncloud/core/issues/37098
+https://github.com/owncloud/core/pull/37148

lib/base.php

@@ -251,7 +251,7 @@ public static function checkConfig() {
 				echo $l->t('This can usually be fixed by giving the webserver write access to the config directory')."\n";
 				echo "\n";
 				echo $l->t('See %s', [ $urlGenerator->linkToDocs('admin-dir_permissions') ])."\n";
-				exit;
+				exit(1);
 			} else {
 				OC_Template::printErrorPage(
 					$l->t('Cannot write into "config" directory!'),
@@ -530,7 +530,7 @@ public static function init() {
 			// we can't use the template error page here, because this needs the
 			// DI container which isn't available yet
 			print($e->getMessage());
-			exit();
+			exit(1);
 		}
 
 		// setup the basic server