Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-zero exit code for non-writable config dir and missing app-di… #37148

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Mar 20, 2020

…r (CLI only)

Description

[CLI] Add non-zero exit code for the non-writable config dir or missing app-dir

Related Issue

How Has This Been Tested?

#37098 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo added this to the development milestone Mar 20, 2020
@VicDeo VicDeo self-assigned this Mar 20, 2020
@update-docs
Copy link

update-docs bot commented Mar 20, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@VicDeo
Copy link
Member Author

VicDeo commented Mar 20, 2020

Note: the changes are not coverable with unit-tests

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #37148 into master will not change coverage by %.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37148   +/-   ##
=========================================
  Coverage     64.85%   64.85%           
  Complexity    19136    19136           
=========================================
  Files          1267     1267           
  Lines         74895    74895           
  Branches       1331     1331           
=========================================
  Hits          48575    48575           
  Misses        25928    25928           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 66.05% <0.00%> (ø) 19136.00 <0.00> (ø)
Impacted Files Coverage Δ Complexity Δ
lib/base.php 3.81% <0.00%> (ø) 152.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da92e15...6772235. Read the comment docs.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis phil-davis merged commit 2ced00c into master Mar 20, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-exit-code branch March 20, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

occ commands give success status when apps_paths has an error
2 participants