-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.0.0 Master: Google Drive Mounte has files with 0K #2013
Comments
Can't reproduce. Do you have any logs? |
@MTRichards do you use http or https on your instance? |
http only, didn't have a cert there. |
I can confirm this on OC 5RC1. Google drive gets mounted, the files are listed, but they are all of zero length, except one, the only pdf file I have there. That one can be viewed, downloaded normally.The rest of my files that have 0 length are ods and odt. |
@torlasz or @MTRichards Can you provide more information how to reproduce this to @MTGap ? Or do you habe something additional information in the logfiles? |
Now that I checked it, all the files with zero length are Google docs files, created by the Google docs web application. All other files have nonzero length (and behave normally), no matter if I upload them to Google drive directly or through OC. So one problem that confused me is that files created by the Google docs web application are listed as odt/ods files in OC. There is no way to tell from the OC listing if you see an opendocument file or a Google docs file except, that the latter ones all have zero lengths (according to my experience). All in all I see two minor bugs:
|
Yes, that is correct. Google Docs don't count against your Google Drive quota. So, that isn't a bug. I defaulted to exporting the Google Docs to open document files since we are an open source project. You should still be able to download them, I'll investigate. |
When I download the google docs files that are converted to ODF, the files are blank. Will continue testing. |
@MTRichards I'm still working on it. I'd appreciate it if you used your time to test this #2035 instead. |
The downloads come through if you click on the download file action, but don't if you click on the table row. @icewind1991 The downloads break with apps/files/download.php, but not lib/files.php. It breaks because the return of filesize() for Google Docs is 0. However, it doesn't seem to bother it going through lib/files.php I'm not sure how to fix this because I can't tell what the file size is until it is downloaded. |
Still working on WebDAV fix before this is closed. |
@evert Is there a way to disable setting Content-Length for some file downloads? |
yea just return |
Thanks, that worked. |
@MTGap Do you think this is fixed now? And if yes, can it be backported? |
@karlitschek the pull request did not even enter master :-( |
shit. @MTGap What do you suggest to improve this ? |
When I mount google drive in the Feb 28 master branch of 5.0.0, google drive mounts and shows files, but they are all 0k. When I click open, there is nothing in them.
running on openSUSE 12.2 with Firefox
Log in, enabled external storage, mount google drive, and there is the problem.
The text was updated successfully, but these errors were encountered: