Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0 Master: Google Drive Mounte has files with 0K #2013

Closed
MTRichards opened this issue Mar 1, 2013 · 17 comments
Closed

5.0.0 Master: Google Drive Mounte has files with 0K #2013

MTRichards opened this issue Mar 1, 2013 · 17 comments
Labels

Comments

@MTRichards
Copy link
Contributor

When I mount google drive in the Feb 28 master branch of 5.0.0, google drive mounts and shows files, but they are all 0k. When I click open, there is nothing in them.

running on openSUSE 12.2 with Firefox

Log in, enabled external storage, mount google drive, and there is the problem.

@MTGap
Copy link
Contributor

MTGap commented Mar 2, 2013

Can't reproduce. Do you have any logs?

@VicDeo
Copy link
Member

VicDeo commented Mar 2, 2013

@MTRichards do you use http or https on your instance?

@MTRichards
Copy link
Contributor Author

http only, didn't have a cert there.

@torlasz
Copy link

torlasz commented Mar 3, 2013

I can confirm this on OC 5RC1. Google drive gets mounted, the files are listed, but they are all of zero length, except one, the only pdf file I have there. That one can be viewed, downloaded normally.The rest of my files that have 0 length are ods and odt.

@karlitschek
Copy link
Contributor

@torlasz or @MTRichards Can you provide more information how to reproduce this to @MTGap ? Or do you habe something additional information in the logfiles?

@torlasz
Copy link

torlasz commented Mar 3, 2013

Now that I checked it, all the files with zero length are Google docs files, created by the Google docs web application. All other files have nonzero length (and behave normally), no matter if I upload them to Google drive directly or through OC. So one problem that confused me is that files created by the Google docs web application are listed as odt/ods files in OC. There is no way to tell from the OC listing if you see an opendocument file or a Google docs file except, that the latter ones all have zero lengths (according to my experience). All in all I see two minor bugs:

  1. Google docs files are listed as opendocument files in OC
  2. Google docs files have a zero length
    A don't know the format of Google docs files. But chances are little I can do anything with them in OC. So bug ca #2 may actually be a feature in the sense that it prevents me from downloading them directly.

@MTGap
Copy link
Contributor

MTGap commented Mar 3, 2013

Yes, that is correct. Google Docs don't count against your Google Drive quota. So, that isn't a bug. I defaulted to exporting the Google Docs to open document files since we are an open source project. You should still be able to download them, I'll investigate.

@MTRichards
Copy link
Contributor Author

When I download the google docs files that are converted to ODF, the files are blank. Will continue testing.

@MTGap
Copy link
Contributor

MTGap commented Mar 3, 2013

@MTRichards I'm still working on it. I'd appreciate it if you used your time to test this #2035 instead.

@MTGap
Copy link
Contributor

MTGap commented Mar 3, 2013

The downloads come through if you click on the download file action, but don't if you click on the table row.

@icewind1991 The downloads break with apps/files/download.php, but not lib/files.php. It breaks because the return of filesize() for Google Docs is 0. However, it doesn't seem to bother it going through lib/files.php I'm not sure how to fix this because I can't tell what the file size is until it is downloaded.

@MTGap
Copy link
Contributor

MTGap commented May 27, 2013

Still working on WebDAV fix before this is closed.

@MTGap
Copy link
Contributor

MTGap commented May 27, 2013

@evert Is there a way to disable setting Content-Length for some file downloads?

@evert
Copy link

evert commented May 27, 2013

yea just return null

@MTGap
Copy link
Contributor

MTGap commented May 27, 2013

Thanks, that worked.

@karlitschek
Copy link
Contributor

@MTGap Do you think this is fixed now? And if yes, can it be backported?

@DeepDiver1975
Copy link
Member

@karlitschek the pull request did not even enter master :-(
#3392

@karlitschek
Copy link
Contributor

shit. @MTGap What do you suggest to improve this ?

@MTGap MTGap closed this as completed in 0953b68 Jul 23, 2013
MTGap pushed a commit that referenced this issue Aug 3, 2013
@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants