Don't set Content-Length header if size is unknown #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Still broken for WebDAV. Anyway to turn off setting Content-Length for those downloads? |
| header('Content-Type: '.\OC\Files\Filesystem::getMimeType($filename)); | ||
| header("Content-Length: ".\OC\Files\Filesystem::filesize($filename)); | ||
| if ($filesize > -1) { |
There was a problem hiding this comment.
How does sending "Content-Length: 0" make sense?
|
Not tested but looks good 👍 I couldn't find where to set it for WebDAV either. |
MTGap
pushed a commit
that referenced
this pull request
May 27, 2013
Don't set Content-Length header if size is unknown
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #2013
In #3392, Google storage is now returning -2 for Google Docs which have no known file size until completely downloaded.
@icewind1991