Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing a file allows you to set create permissions #20839

Closed
rullzer opened this issue Nov 30, 2015 · 5 comments · Fixed by #21163
Closed

Sharing a file allows you to set create permissions #20839

rullzer opened this issue Nov 30, 2015 · 5 comments · Fixed by #21163

Comments

@rullzer
Copy link
Contributor

rullzer commented Nov 30, 2015

share

The webinterface allows us to set create permissions on files. This does not make any sense since on the FS files do not even have create permissions (so we increase the permissions for a shared file). I also would have no idea what this would mean.

The old sharing code actually happily allows you to set create permissions. However nothing bad (usually) happens since the actions create gives you are not valid for files anyway.

We should remove the craete permissions from the webinterface.

CC: @PVince81

@rullzer rullzer added this to the 9.0-current milestone Nov 30, 2015
@rullzer
Copy link
Contributor Author

rullzer commented Nov 30, 2015

The new sharing code actually does not allow this. Since it checkes if we do not increase permissions.

@PVince81
Copy link
Contributor

PVince81 commented Dec 8, 2015

Looks like it was introduced by the move to Webdav. "data-sharepermissions" isn't computed the same it seems.

@PVince81
Copy link
Contributor

PVince81 commented Dec 8, 2015

Fix must be done here: https://github.com/owncloud/core/blob/master/core/js/files/client.js#L297
This is the Webdav permission to OC permission conversion.

@rullzer
Copy link
Contributor Author

rullzer commented Dec 11, 2015

PR in #21163

@lock
Copy link

lock bot commented Aug 7, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants