-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to create a read-write public share of a file #31538
Labels
Milestone
Comments
@PVince81 @patrickjahns or anybody, does the current behavior seem OK? |
Considering that we don't support creating public links for files with read-write permissions as we haven't tested the implications in public link page, we should likely block it on API level for now. |
This issue has been automatically closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps to reproduce
tests/acceptance/features/apiSharing-v1/createShare.feature:75
Expected behaviour
Maybe an attempt to make a public share of a file with read and write permissions should fail with some
4nn
HTTP status?Actual behaviour
The test scenario makes a public share of file
welcome.txt
with all permissions (read, write, reshare...). The public share creation succeeds and the public share actually just has read permission.Server configuration
drone CI or local dev environment
See PR #31495 where the test scenario was added.
The text was updated successfully, but these errors were encountered: