Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API test for creating a public read-write share of a file #31495

Merged
merged 1 commit into from
May 23, 2018

Conversation

phil-davis
Copy link
Contributor

Description

Try to create a public read-write share of a single file, and see that it results in a read-only share.

Related Issue

#31366

Motivation and Context

It is nice to know what happens if someone attempts to create a public share of a single file with read-write permissions.

How Has This Been Tested?

Run the new acceptance test.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New acceptance test

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis
Copy link
Contributor Author

This seemed worth having in an acceptance test.
The API call does not fail - it just gives the share less permissions than requested.
I guess that behavior is OK/reasonable?

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #31495 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31495   +/-   ##
=========================================
  Coverage      62.6%    62.6%           
  Complexity    18271    18271           
=========================================
  Files          1147     1147           
  Lines         68621    68621           
  Branches       1234     1234           
=========================================
  Hits          42963    42963           
  Misses        25297    25297           
  Partials        361      361
Flag Coverage Δ Complexity Δ
#javascript 52.05% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.8% <ø> (ø) 18271 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4152756...2821e73. Read the comment docs.

@individual-it
Copy link
Member

backport?

@phil-davis
Copy link
Contributor Author

Backport stable10 #31504

@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants