Sharing a single file

[LiohMoeller]

I have noticed that the end-user frontend of a single shared file, is not very usable. The link to the file is placed in the top right corner and there is a big empty space below:

It makes it really hard to find and I often have to tell pll how to download it.

It would be great if the file is listed in that light-gray space as it is the case on sharing a folder.

[Niduroki]

@jancborchardt

[LiohMoeller]

Another option might be to directly link the file, without showing the UI at all.

[jancborchardt]

Ok, this depends on the file type. If it can’t be previewed, the download link should obviously be centered. in the light grey area.

I’m thinking:

• Show the »Marcus shared a file image.jpg with you« above the file (not in the header)
• and show the download button below the file preview, next to it could also be the direct link to the file in an input field, fixing Can't share images for real #1167 as well.

When there’s no preview, there would simply be the message and the download link, central and visible.

Someone wants to check this out? @Kondou-ger @mjob?

[jancborchardt]

I meant @kabum, not @mjob. Morris, different names are confusing ;)

[MTGap]

A message is supposed to be in the center. Something is broken, look at your Javascript console.

[MorrisJobke]

It seems to be previewed, but the underlying DOM has changed. Fileactions looks for "data-mime", "data-file", etc attributes (see https://github.com/owncloud/core/blob/master/apps/files/js/fileactions.js#L139 following).

The share scripts but these information in some input fields(first lines of https://github.com/owncloud/core/blob/master/apps/files_sharing/templates/public.php).

I'm not willed to solve this, because it's a really hard task and I want to do some minor issues and then concentrate on the media app, sorry. Maybe @Kondou-ger will have a look :) ... or @icewind1991 because he is the files app maintainer and it's his department.

[MTGap]

I can't tell what broke it. I don't feel like dedicating hours into investigating it when I'd rather like to see us standardize the file previewers.

It would be helpful if someone could figure out which commit broke it.

[Niduroki]

Shouldn't it be like that?

With files where no app tries to preview it, it works in both stable5 and master for me. So it has something to do with apps trying to preview it …
The "No preview available" is there, but display: noned …

[MTGap]

Yes, it's broken for all files that should have previews. Except images and videos which are done manually.

[jancborchardt]

Hm, what’s the status on this one?

[MorrisJobke]

It gets previewed.