Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS tests failing after npm / jasmine update #22123

Closed
PVince81 opened this issue Feb 4, 2016 · 3 comments · Fixed by #22130
Closed

JS tests failing after npm / jasmine update #22123

PVince81 opened this issue Feb 4, 2016 · 3 comments · Fixed by #22130
Assignees
@PVince81
Labels
sev2-high Type:Bug
Milestone
9.0

Comments

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016 

PhantomJS 2.1.1 (Linux 0.0.0) OC.Files.Client tests file listing throws exception if arguments are missing FAILED
        Expected undefined to equal 51.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:250:28
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected '//path/to space/文件夹' to equal '/path/to space/文件夹'.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:251:30
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected 27 to equal 31.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:253:37
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected undefined to equal 15.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:262:28
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected '//path/to space/文件夹' to equal '/path/to space/文件夹'.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:263:30
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected undefined to equal 11.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:293:28
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected '//path/to space' to equal '/path/to space'.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:294:30
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected undefined to equal 51.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:303:35
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
        Expected undefined to equal 15.
        /srv/www/htdocs/owncloud/core/js/tests/specs/files/clientSpec.js:304:35
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54398
        c@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:26055
        fireWith@/srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:52724
        /srv/www/htdocs/owncloud/core/vendor/jquery/jquery.min.js:4:54814
        /srv/www/htdocs/owncloud/core/js/files/client.js:409:22
        lib$es6$promise$$internal$$tryCatch@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:331:24
        lib$es6$promise$$internal$$invokeCallback@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:343:52
        lib$es6$promise$$internal$$publish@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:314:52
        lib$es6$promise$asap$$flush@/srv/www/htdocs/owncloud/core/vendor/es6-promise/dist/es6-promise.js:125:17
.........................................
WARN: 'Missing plural form in language file'

Also happens on CI when running on some servers that have a more recent version.

Seems to be related to the promise stuff.
@PVince81 PVince81 self-assigned this Feb 4, 2016
@PVince81 PVince81 added this to the 9.0-current milestone Feb 4, 2016
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 4, 2016

I think these tests should be decoupled from davclient.js so instead of using fakeServer, just mock the library.

davclient.js needs its own tests.

This was referenced Feb 4, 2016
Merged
Merged
@PVince81
Copy link
Contributor Author

PVince81 commented Feb 4, 2016

Fix is here #22130

@lock
Copy link

lock bot commented Aug 6, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@PVince81 PVince81

Labels
sev2-high Type:Bug
Projects
None yet
Milestone
9.0
Development

Successfully merging a pull request may close this issue.

Fix jsunit filesclient owncloud/core
2 participants
@PVince81 @DeepDiver1975