-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add global auth backend for files external #22107
Conversation
/** | ||
* @author Robin Appelman <icewind@owncloud.com> | ||
* | ||
* @copyright Copyright (c) 2015, ownCloud, Inc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you live in the past!
Code looks good otherwise, a quick test showed that it works. Please move the fields above the storages table and this is good to go. |
Fixes #21991 |
In WND, global credentials was available for admin and users:
Correct me if I'm wrong but here is only for admin. Other thing that we should think is to turn some of this enhancements to only EE flavour, if we want to have an EE version more valuable. |
Right, I forgot to check the personal page, thanks for pointing out @jmaciasportela @icewind1991 can you add a set of credentials there too ? |
ee42a37
to
6549f52
Compare
Now also works for personal mounts |
6549f52
to
df5c50c
Compare
JS unit failures unrelated: #22123 |
@icewind1991 the password field is missing a "placeholder" attribute |
Tested, works 👍 |
For some reason I was convinced that the password obfuscation thing also applied to placeholders... |
@icewind1991 no, that bug is only with IE <= 9 I think... |
df5c50c
to
9dfe9f7
Compare
now with placeholder
I think my believe is caused by chrome's over eagerness of autofiling the password |
@jmaciasportela second review ? |
👍 |
Add global auth backend for files external
@PVince81 @icewind1991 I figure out that if you have a mount point with global credentials with green status, and change global credentials, mount point still green. It would be good if we recheck the status in all mount points that use global credentials. |
@jmaciasportela can you make a ticket ? CC @SergioBertolinSG @Xenopathic |
cc @PVince81 @Xenopathic