Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add global auth backend for files external #22107

Merged
merged 1 commit into from
Feb 4, 2016

Conversation

icewind1991
Copy link
Contributor

cc @PVince81 @Xenopathic

@icewind1991 icewind1991 added this to the 9.0-current milestone Feb 3, 2016
@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @PVince81, @Xenopathic and @rnicoll to be potential reviewers

/**
* @author Robin Appelman <icewind@owncloud.com>
*
* @copyright Copyright (c) 2015, ownCloud, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you live in the past!

@PVince81
Copy link
Contributor

PVince81 commented Feb 3, 2016

Code looks good otherwise, a quick test showed that it works.

Please move the fields above the storages table and this is good to go.

@PVince81
Copy link
Contributor

PVince81 commented Feb 3, 2016

Fixes #21991

@jmaciasportela
Copy link
Contributor

In WND, global credentials was available for admin and users:

  • Admin: for whole systems
  • User: for their personal mount points

Correct me if I'm wrong but here is only for admin.

Other thing that we should think is to turn some of this enhancements to only EE flavour, if we want to have an EE version more valuable.

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

Right, I forgot to check the personal page, thanks for pointing out @jmaciasportela

@icewind1991 can you add a set of credentials there too ?

@icewind1991
Copy link
Contributor Author

Now also works for personal mounts

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

JS unit failures unrelated: #22123

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

@icewind1991 the password field is missing a "placeholder" attribute

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

Tested, works 👍

@icewind1991
Copy link
Contributor Author

the password field is missing a "placeholder" attribute

For some reason I was convinced that the password obfuscation thing also applied to placeholders...

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

@icewind1991 no, that bug is only with IE <= 9 I think...

@icewind1991
Copy link
Contributor Author

now with placeholder

no, that bug is only with IE <= 9 I think...

I think my believe is caused by chrome's over eagerness of autofiling the password

@PVince81
Copy link
Contributor

PVince81 commented Feb 4, 2016

@jmaciasportela second review ?

@jmaciasportela
Copy link
Contributor

👍

DeepDiver1975 added a commit that referenced this pull request Feb 4, 2016
Add global auth backend for files external
@DeepDiver1975 DeepDiver1975 merged commit 089b60c into master Feb 4, 2016
@DeepDiver1975 DeepDiver1975 deleted the external-auth-global branch February 4, 2016 15:18
@jmaciasportela
Copy link
Contributor

@PVince81 @icewind1991 I figure out that if you have a mount point with global credentials with green status, and change global credentials, mount point still green. It would be good if we recheck the status in all mount points that use global credentials.

@PVince81
Copy link
Contributor

PVince81 commented Feb 5, 2016

@jmaciasportela can you make a ticket ?

CC @SergioBertolinSG @Xenopathic

@jmaciasportela
Copy link
Contributor

#22144

@lock lock bot locked as resolved and limited conversation to collaborators Aug 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants