Fix jsunit filesclient #22130
Merged
Fix jsunit filesclient #22130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 4, 2016 15:38
Remove double leading slash in path. Add utf-8 in default content type.
Instead of trying to mock the promise, just stub davclient.js' request object.
|
By analyzing the blame information on this pull request, we identified @DeepDiver1975 to be a potential reviewer |
|
If you wonder why I changed some test results and add "oc:fileid": turns out that the tests weren't failing properly when run in phantomjs, but did in Chromium. Now with the upgrade to the newer phantomjs versions they also do fail there. That's why it only started failing now: #22123. Why they didn't fail, I suppose it was due to the ES6 Promise shim that somehow made it not run some of the I adjusted the tests to match some older changes which were supposed to break the tests but didn't, due to the reason explained above. |
|
Works fine 👍 |
|
👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22123
This will make the JS unit tests on master pass again.
Please review @rullzer @blizzz @icewind1991 @MorrisJobke @nickvergessen @DeepDiver1975