[Share 2.0] Add missing post_update_permissions hook #22118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code looks good 👍 I'll have a look at the failing JS tests separately, seems to be random. |
| 'shareWith' => $share->getSharedWith(), | ||
| 'uidOwner' => $share->getSharedBy(), | ||
| 'permissions' => $share->getPermissions(), | ||
| 'path' => $share->getNode()->getPath(), |
There was a problem hiding this comment.
While I prefer this one, the old hook sent the local path, not the absolute path
8.2
Info sharing_log User admin shared "/test2" with the user test1, permissions: READ UPDATE CREATE DELETE SHARE [CLIENT_IP: 127.0.0.1] 2016-02-04T12:11:01+00:00
Info sharing_log User admin updated the permissions for "/test/test2" for the user test1, permissions: READ UPDATE CREATE DELETE [CLIENT_IP: 127.0.0.1] 2016-02-04T12:11:02+00:00
This PR
Info admin_audit User admin shared "/test2" with the user test1, permissions: READ UPDATE CREATE DELETE SHARE [CLIENT_IP: 127.0.0.1] 2016-02-04T12:11:53+00:00
Info admin_audit User admin updated the permissions for "/admin/files/test/test2" for the user test1, permissions: READ UPDATE CREATE DELETE [CLIENT_IP: 127.0.0.1] 2016-02-04T12:11:54+00:00
There was a problem hiding this comment.
fixed... should be the relative path now...
|
Triple unlucky:
|
|
👍 Fixes admin_audit |
|
needs rebase |
rullzer
force-pushed
the
post_update_permissions_hook
branch
from
eb195a3 to
1698749
Compare
|
Rebased |
DeepDiver1975
added a commit
that referenced
this pull request
Feb 5, 2016
[Share 2.0] Add missing post_update_permissions hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nickvergessen as prommised.
CC: @schiesbn @nickvergessen @PVince81