-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User admin page fails to load properly after upgrade to oc 9.0.2 #24734
Comments
Important info from the other ticket, reposting:
Now with only 5 groups the page shouldn't be that slow. With 330 users, the ajax call should only load the first 20 users. So far I don't see what could be causing the JS code to slow down. |
I see the JS stack trace about adding users, let's check the code to find more clues:
It is unlikely to be due to slow ajax because then there wouldn't be a JS timeout. |
Interesting, the stack above points at the code that renders the subadmin groups dropdown. @pako81 are there special characters in group names ? Are there many subadmins ? Trying to find out the relationship between users/groups/subadmins. Maybe a screenshot from when the page loaded could help from the rare times where the page does load properly (share privately on S3 in case of confidential info, I do want to have a look at the group names too for clues). |
I did the following test locally:
It looks like now in 9.0.2 the page loads 300 entries at once instead of 20, maybe because people complained about the pagination being too small. On my env it takes 4-5 seconds to render the page in Firefox, I'm not getting any JS timeouts. I do notice that there are a few seconds where the spinner stops moving, which is usually a sign of JS code blocking the browser. |
Quick workaround: edit https://github.com/owncloud/core/blob/v9.0.2/settings/js/users/users.js#L17 and set the value to a smaller one like 50 or 100. Still, I find that the fact that it's taking minutes for JS suspicious, maybe there are some extra processing triggered by a specific configuration/combination of groups. |
@PVince81 not sure. @brtptrs could you please comment here ? You could also send the screenshot from when the page loaded to my personal email (in case of confidential info) and I will take care to upload it to S3.
@brtptrs could you also try the suggested workaround and see if this helps in speeding up the loading of the page ? |
@PVince81 yes, did the same test yesterday in 9.0.2 with more than 300 users and they were all displayed at once. I was however not able to find the PR where we changed the pagination settings.. |
ah ok :) |
Note: that change is only in 9.0. The backport was denied due to other perf regressions in 8.2 due to avatars and other stuff. |
@PVince81 Yes, there are special characters all over the place, is't German, but no subadmins. I'll try the workaround and report back. |
@PVince81 the workaround solves the problem for me. Thanks! |
Hmmm ok... Is that Firefox running on an older/slower machine perhaps ? |
Not really old |
workaround doesn't work for me. is tehre any chance for a solution? |
@florian0402 what are your symptoms before and after the workaround ? |
everytime i want to load the users page, the js error appears. i get the same error like @brtptrs (before and after the workaround) |
@florian0402 does it happen if you set the user limit to 20 ? This was the original value in the old version. So far I'm still surprised that it's that slow even with less users. |
@PVince81 it's getting better. it's not really fast, but it works with 20! |
The ultimate fix will be #9201 but it isn't ready as it's bigger changes. The users page is quite old and uses unefficient ways to load groups, that PR improves that. |
Yeah, or 50 if that value works better. |
Prevents timeouts on the initial loading of users. proper fix will be in owncloud/core#10994 Workaround for owncloud/core#24734
Closing. Follow up in the proper fix ticket #9201 |
The workaround that reduces the page size will be in 9.0.3 |
Prevents timeouts on the initial loading of users. proper fix will be in owncloud/core#10994 Workaround for owncloud/core#24734
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Steps to reproduce
Expected behaviour
List of users get loaded
Actual behaviour
The page takes minutes to load, and often does not load at all, ending with a js error
"Ein Skript auf dieser Seite ist eventuell beschäftigt oder es antwortet nicht mehr. Sie können das Skript jetzt stoppen, im Debugger öffnen oder weiter ausführen."
Using the ajax search box shows the same behaviour.
Server configuration
Operating system:CentOS
**Web server:**Apache
**Database:**MySQL
**PHP version:**5.6
ownCloud version: OC EE 9.0.2
Updated from an older ownCloud or fresh install: Update from EE 8.2
Where did you install ownCloud from:
Signing status (ownCloud 9.0 and above):
List of activated apps:
Activity
Antivirus App for files
Comments
Deleted files
Enterprise license key
External Sites
External storage support
Federation
File firewall
First Run Wizard
Gallery
Log user and file sharing actions
Mail Template Editor
Notifications
Provisioning API
Share Files
Text Editor
Update notification
Versions
Workflow
Announcement Center
Are you using external storage, if yes which one: No
Are you using encryption: No
Are you using an external user-backend, if yes which one: No
Client configuration
Browser: Firefox 46 or Chrome 50
Operating system: Ubuntu Linux 15.10
Logs
Web server error log
ownCloud log (data/owncloud.log)
Browser log
The text was updated successfully, but these errors were encountered: