Remove empty code blocks

[settermjd]

After reviewing the code, I've come across a number of empty code blocks that serve no purpose. Perhaps, at some earlier time, they were used but have gradually been trimmed down over time until they are now empty, yet never removed. Regardless, as they no longer serve any purpose, other than to cause confusion, it's best to remove them.

They are:

https://github.com/owncloud/core/blob/master/apps/files_sharing/lib/Helper.php#L143
https://github.com/owncloud/core/blob/master/lib/private/App/CodeChecker/NodeVisitor.php#L136
https://github.com/owncloud/core/blob/master/lib/private/Archive/ZIP.php#L46
https://github.com/owncloud/core/blob/master/lib/private/App/CodeChecker/NodeVisitor.php#L136
https://github.com/owncloud/core/blob/master/lib/private/App/CodeChecker/NodeVisitor.php#L164
https://github.com/owncloud/core/blob/master/lib/private/App/CodeChecker/NodeVisitor.php#L180
https://github.com/owncloud/core/blob/master/tests/data/app/code-checker/test-not-equal.php#L8
https://github.com/owncloud/core/blob/master/tests/data/app/code-checker/test-identical-operator.php#L8
https://github.com/owncloud/core/blob/master/tests/data/app/code-checker/test-identical-operator.php#L10
https://github.com/owncloud/core/blob/master/tests/data/app/code-checker/test-equal.php#L8
https://github.com/owncloud/core/blob/master/lib/private/Files/Storage/Common.php#L430

[ownclouders]

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #240 (--- Removed ---), #3260 (- Removed -), #31888 (removed dead code), #31889 ([stable10] remove dead code), and #28612 (Remove unused win code (#28609)).

[PVince81]

all are harmless.

the code checker has its own test data with dummy classes, not code that actually runs.

The last one we'll need to address at some point: https://github.com/owncloud/core/blob/master/lib/private/Files/Storage/Common.php#L430

From what I see this method was added by mistake and should have used normalizePath() instead:

• Approach 1:
  • remove Common::cleanPath (it's not on any interface)
  • remove cleanPath usage in SFTP and make it use Filesystem::normalizePath() instead
  • cons: in case other ext storages use it, they'll break
  • pros: cleaner classes...
• Approach 2:
  • reimplement cleanPath like DAV https://github.com/owncloud/core/blob/v10.0.9/lib/private/Files/Storage/DAV.php#L627
  • adjust DAV storage to use the Common method
  • pro: existing subclasses that might use it like SFTP will continue working

[emjrymer]

I'd be happy to help clean this up!