Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused win code #28609

Merged
merged 2 commits into from
Aug 8, 2017
Merged

Remove unused win code #28609

merged 2 commits into from
Aug 8, 2017

Conversation

phil-davis
Copy link
Contributor

Description

Remove unused Windows code in core test infrastructure

Related Issue

Motivation and Context

Cleanup stuff when I notice it

How Has This Been Tested?

CI still runs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PVince81
Copy link
Contributor

PVince81 commented Aug 8, 2017

conflict ?!

@phil-davis
Copy link
Contributor Author

yes, I removed other code from right next to this last night. That is how I happened to notice it.

@phil-davis phil-davis added this to the development milestone Aug 8, 2017
@phil-davis
Copy link
Contributor Author

I don't see how this "if" block will ever be used any more. Someone reviewing can confirm that they agree.

PVince81
PVince81 approved these changes Aug 8, 2017
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 22703cb into master Aug 8, 2017
@PVince81 PVince81 deleted the preseed-config-win branch August 8, 2017 07:24
phil-davis added a commit that referenced this pull request Aug 8, 2017
@phil-davis
Remove unused win code (#28609)
1907a97
@phil-davis phil-davis mentioned this pull request Aug 8, 2017
Merged
PVince81 pushed a commit that referenced this pull request Aug 8, 2017
Merge pull request #28612 from owncloud/stable10-preseed-config-win
f147e46 
Remove unused win code (#28609)
@ownclouders ownclouders mentioned this pull request Sep 13, 2018
Open
@lock
Copy link

lock bot commented Aug 2, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@individual-it individual-it Awaiting requested review from individual-it

@davitol davitol Awaiting requested review from davitol

@SergioBertolinSG SergioBertolinSG Awaiting requested review from SergioBertolinSG

Assignees
No one assigned
Labels
3 - To Review status/STALE
Projects
None yet
Milestone
10.0.3
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-davis @PVince81 @ownclouders