Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable10] remove dead code #31889

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Conversation

patrickjahns
Copy link
Contributor

backport of #31888

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • backport

@patrickjahns patrickjahns added this to the development milestone Jun 25, 2018
@patrickjahns patrickjahns self-assigned this Jun 25, 2018
@codecov
Copy link

codecov bot commented Jun 25, 2018

Codecov Report

Merging #31889 into stable10 will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #31889      +/-   ##
==============================================
+ Coverage       62.45%   62.45%   +<.01%     
+ Complexity      18588    18587       -1     
==============================================
  Files            1210     1210              
  Lines           72779    72773       -6     
  Branches         1273     1273              
==============================================
  Hits            45454    45454              
+ Misses          26945    26939       -6     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 52.71% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 63.53% <100%> (ø) 18587 <0> (-1) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/Migration.php 97.08% <100%> (+5.34%) 20 <0> (-1) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 561f110...22f3b9c. Read the comment docs.

@patrickjahns
Copy link
Contributor Author

Needs a second look as cherry-picking lead to unwanted changes 😠

@phil-davis
Copy link
Contributor

phil-davis commented Jun 26, 2018

Needs ownCloud coding standard #31828 applied to stable10 so that this does not happen to people on every little backport. But that is waiting for after 10.0.9 is sorted.

@PVince81 PVince81 mentioned this pull request Jun 27, 2018
4 tasks
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra changes look fine, related to code style. 👍

Not merging because of freeze

@DeepDiver1975 DeepDiver1975 merged commit dc5d226 into stable10 Jul 18, 2018
@DeepDiver1975 DeepDiver1975 deleted the stable10_cleanup_dead_code branch July 18, 2018 07:04
@PVince81 PVince81 modified the milestones: development, QA Sep 5, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants