[stable10] owncloud coding standard

[phil-davis]

Backport #31442

The first commits backport the various interim php-cs-fixer changes from PR #31198 #31236 #31250 #31271 #31273

That was the easy way to make a list of cherry-picks that all fit nicely on top of each other. And its brings along the Makefile and drone changes etc that were already done before #31442

The last commits use php-cs-fixer to make the automatic fixes needed for the code in stable10

lib/composer/bin/php-cs-fixer fix -v --diff --diff-format udiff --allow-risky yes

[phil-davis]

Note: For now, this is just a place to keep a handy list of all the commits that make up implementing the code-style checks. The last commit(s) that actually apply the changes to the code can easily be dropped and then re-made by running the checker to make the fixes. That is often easier (and more reliable) than manually resolving loads of "rubbish" conflicts that happen here.

[codecov]

Codecov Report

Merging #31828 into stable10 will decrease coverage by 0.05%.
The diff coverage is 70.53%.

@@              Coverage Diff               @@
##             stable10   #31828      +/-   ##
==============================================
- Coverage       62.45%   62.39%   -0.06%     
+ Complexity      18622    18612      -10     
==============================================
  Files            1213     1213              
  Lines           72902    72989      +87     
  Branches         1273     1273              
==============================================
+ Hits            45530    45542      +12     
- Misses          26992    27067      +75     
  Partials          380      380

Flag	Coverage Δ	Complexity Δ
#javascript	52.71% <ø> (ø)	0 <ø> (ø)	⬇️
#phpunit	63.45% <70.53%> (-0.07%)	18612 <692> (-10)

Impacted Files	Coverage Δ	Complexity Δ
apps/dav/lib/CardDAV/ContactsManager.php	100% <ø> (ø)	4 <0> (ø)	⬇️
apps/files_external/lib/AppInfo/Application.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files/templates/index.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files_external/lib/Command/Export.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files/templates/simplelist.php	0% <ø> (ø)	0 <0> (ø)	⬇️
apps/files/simplelist.php	0% <ø> (ø)	0 <0> (ø)	⬇️
...ps/files/lib/BackgroundJob/DeleteOrphanedItems.php	89.58% <ø> (ø)	9 <0> (ø)	⬇️
apps/federation/lib/DAV/FedAuth.php	100% <ø> (ø)	2 <0> (ø)	⬇️
...v/lib/Connector/Sabre/Exception/EntityTooLarge.php	0% <ø> (ø)	1 <0> (ø)	⬇️
...Connector/Sabre/Exception/UnsupportedMediaType.php	0% <ø> (ø)	1 <0> (ø)	⬇️
... and 592 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc853d4...7dfe0aa. Read the comment docs.

[patrickjahns]

This only makes sense after 10.0.9

[phil-davis]

@patrickjahns you had a comment back in the original incarnation of this backport:
#31453 (comment)

"There are some open tasks that need to be checked on stable10 - especially if native_function breaks polyfill components"

Is there something special we should do to double-check that things are OK after these changes?

[phil-davis]

Note: I will rebase or recreate this on Friday. Then it can be discussed, if it gets merged to stable10 now.

[phil-davis]

See PR #32103 for the next cut at this.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.