php-cs-fixer fix . --rules=native_function_invocation #31198

DeepDiver1975 · 2018-04-19T10:20:39Z

Description

php functions should be called with their full namespace
one of many resource about the details: https://veewee.github.io/blog/optimizing-php-performance-by-fq-function-calls/

Motivation and Context

Write proper code
Give the code some speedup

How Has This Been Tested?

Pure unit testing

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes.
All new and existing tests passed.

codecov · 2018-04-19T10:42:58Z

Codecov Report

Merging #31198 into master will increase coverage by <.01%.
The diff coverage is 65%.

@@             Coverage Diff              @@
##             master   #31198      +/-   ##
============================================
+ Coverage     62.57%   62.57%   +<.01%     
+ Complexity    18412    18234     -178     
============================================
  Files          1145     1145              
  Lines         68416    68396      -20     
  Branches       1234     1234              
============================================
- Hits          42809    42799      -10     
+ Misses        25246    25236      -10     
  Partials        361      361

Flag	Coverage Δ	Complexity Δ
#javascript	`52.05% <ø> (ø)`	`0 <ø> (ø)`	⬇️
#phpunit	`63.77% <65%> (ø)`	`18234 <25> (-178)`	⬇️

Impacted Files	Coverage Δ	Complexity Δ
...deratedfilesharing/templates/settings-personal.php	`100% <ø> (ø)`	`0 <0> (ø)`	⬇️
apps/dav/lib/CalDAV/CalendarObject.php	`96.77% <ø> (ø)`	`18 <0> (ø)`	⬇️
...s/dav/appinfo/Migrations/Version20170519091921.php	`0% <ø> (ø)`	`1 <0> (ø)`	⬇️
apps/files_sharing/templates/public.php	`0% <ø> (ø)`	`0 <0> (ø)`	⬇️
apps/dav/lib/Files/RootCollection.php	`15.38% <0%> (ø)`	`4 <0> (ø)`	⬇️
apps/dav/lib/CalDAV/Plugin.php	`0% <0%> (ø)`	`2 <0> (ø)`	⬇️
apps/files_sharing/lib/Activity.php	`5.34% <0%> (ø)`	`97 <0> (ø)`	⬇️
apps/files_trashbin/appinfo/update.php	`0% <0%> (ø)`	`0 <0> (ø)`	⬇️
apps/files_trashbin/appinfo/app.php	`54.54% <0%> (ø)`	`0 <0> (ø)`	⬇️
apps/files/lib/ActivityHelper.php	`0% <0%> (ø)`	`8 <0> (ø)`	⬇️
... and 180 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10b91a7...f929720. Read the comment docs.

mmattel · 2018-04-20T07:36:57Z

WOW
If this gets merged, we need to add a note in the developer guide !
I file a small reminder in documentation
@settermjd

mmattel · 2018-04-20T07:49:32Z

@DeepDiver1975 if this gets merged, we will have code added in the meanwhile which does not have the namespace added. How can we make sure we can
a.) identify these elements and
b.) post-change them
I guess that the process of a+b will be needed to rerun from time to time...

DeepDiver1975 · 2018-04-20T07:51:05Z

I guess that the process of a+b will be needed to rerun from time to time...

I did add the php-cs-fixer as drone step - as soon as anybody violates the rules - the build will fail

mmattel · 2018-04-20T07:59:52Z

This is great for new PR´s an thanks for higlighting this as this is a very important doc-note !

But this also means a one time delta job for those PR´s which are not covered by this one but merged in between. May I assume that you volunteer to fix them 😄

DeepDiver1975 · 2018-04-20T08:02:52Z

May I assume that you volunteer to fix them smile

anybody can easily run the php-cs-fixer to not only detect the changes but also to apply them.
we will fix this which in a short period of time

mmattel · 2018-04-20T08:19:12Z

Now I see it, php-cs-fixer is in composer.lock

butonic

❤️

butonic

and some more ...

butonic · 2018-04-20T19:15:20Z

composer.lock

        },
        {
            "name": "paragonie/random_compat",
-            "version": "v2.0.12",
+            "version": "v2.0.11",


@DeepDiver1975 downgrade?

butonic · 2018-04-20T19:15:37Z

composer.lock

        },
        {
            "name": "phpseclib/phpseclib",
-            "version": "2.0.11",
+            "version": "2.0.10",


butonic · 2018-04-20T19:16:08Z

composer.lock

        },
        {
            "name": "sabre/vobject",
-            "version": "4.1.6",
+            "version": "4.1.5",


butonic · 2018-04-20T19:16:37Z

composer.lock

        },
        {
            "name": "symfony/console",
-            "version": "v3.4.8",
+            "version": "v3.4.6",


butonic · 2018-04-20T19:16:58Z

composer.lock

        },
        {
            "name": "symfony/debug",
-            "version": "v3.4.8",
+            "version": "v3.4.6",


butonic · 2018-04-20T19:17:49Z

composer.lock

                "shasum": ""
            },
            "require": {
                "php": "^5.5.9|>=7.0.8"
            },
            "conflict": {
-                "symfony/config": "<3.3.1",
+                "symfony/config": "<2.8",


butonic · 2018-04-20T19:18:03Z

composer.lock

        },
        {
            "name": "symfony/translation",
-            "version": "v3.4.8",
+            "version": "v3.4.6",


butonic · 2018-04-20T19:18:12Z

composer.lock

        },
        {
            "name": "zendframework/zend-filter",
-            "version": "2.8.0",
+            "version": "2.7.2",


butonic · 2018-04-20T19:18:25Z

composer.lock

-            },
-            "conflict": {
-                "zendframework/zend-validator": "<2.10.1"
+                "php": "^5.5 || ^7.0",


butonic · 2018-04-20T19:18:35Z

composer.lock

-            "conflict": {
-                "zendframework/zend-validator": "<2.10.1"
+                "php": "^5.5 || ^7.0",
+                "zendframework/zend-stdlib": "^2.7 || ^3.0"


mmattel · 2018-04-21T08:35:01Z

@DeepDiver1975 question: what is the impact to other repositories if there is one, lets take as an example oauth2 (could be any other). How can those be improved by this approach ?

…rules as defined in .php_cs

DeepDiver1975 · 2018-04-21T09:02:21Z

@DeepDiver1975 question: what is the impact to other repositories if there is one, lets take as an example oauth2 (could be any other). How can those be improved by this approach ?

we will step by step introduce php-cs-fixer to all other repos as well.

patrickjahns · 2018-04-21T11:21:50Z

Backport to stable10 please - keep coding style consistent

phil-davis · 2018-04-21T11:38:06Z

Yes, and it will minimize pain for future backports.

patrickjahns · 2018-04-21T14:08:49Z

Before Backporting:

I had a bit of more time to think and check other projects using / implementing it - and I would actually prefer the approach the doctrine project went ahead:

instead of using \ for all global functions (i.e. \ltrim()...) they use function imports

use function ltrim;
ltrim()

ref: doctrine/orm#6807

Example: https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Query.php

while this is merged now it doesn't mean we have to stick with it - we could create codesniffer rules: https://github.com/doctrine/coding-standard/pull/15/files

phil-davis · 2018-05-16T04:23:20Z

Note: backport of this is likely to be superceded by the "ownCloud coding standard" implementation in PR #31442

phil-davis · 2018-05-16T09:16:18Z

Effective backport is included in #31453

lock · 2019-07-31T01:02:14Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

DeepDiver1975 added the 3 - To Review label Apr 19, 2018

DeepDiver1975 added this to the development milestone Apr 19, 2018

DeepDiver1975 self-assigned this Apr 19, 2018

DeepDiver1975 requested review from PVince81 and butonic April 19, 2018 10:20

DeepDiver1975 force-pushed the code-quality/fully-qualified-function-calls branch from 8908f52 to fa32be5 Compare April 20, 2018 06:38

DeepDiver1975 force-pushed the code-quality/fully-qualified-function-calls branch from fa32be5 to 1959cc9 Compare April 20, 2018 07:55

butonic approved these changes Apr 20, 2018

View reviewed changes

DeepDiver1975 force-pushed the code-quality/fully-qualified-function-calls branch 3 times, most recently from ca9eeee to f670116 Compare April 20, 2018 12:55

butonic requested changes Apr 20, 2018

View reviewed changes

butonic approved these changes Apr 20, 2018

View reviewed changes

butonic force-pushed the code-quality/fully-qualified-function-calls branch from ac94ad1 to 73b02b1 Compare April 20, 2018 19:35

DeepDiver1975 force-pushed the code-quality/fully-qualified-function-calls branch from cc3f83d to 2537c57 Compare April 20, 2018 22:03

DeepDiver1975 added 3 commits April 21, 2018 11:00

php-cs-fixer fix . --rules=native_function_invocation

6b521b4

Add make target test-php-style which executes php-cs-fixer to verify …

4ae3405

…rules as defined in .php_cs

Add make test-php-style to drone

f929720

DeepDiver1975 force-pushed the code-quality/fully-qualified-function-calls branch from 2537c57 to f929720 Compare April 21, 2018 09:01

DeepDiver1975 merged commit f2543f6 into master Apr 21, 2018

DeepDiver1975 deleted the code-quality/fully-qualified-function-calls branch April 21, 2018 09:54

phil-davis added the backport-request label Apr 21, 2018

phil-davis mentioned this pull request Apr 23, 2018

Specifically exclude anything other than the core bundled apps #31236

Merged

9 tasks

phil-davis mentioned this pull request May 16, 2018

[stable10] owncloud coding standard #31453

Closed

phil-davis removed the backport-request label May 16, 2018

This was referenced Jun 6, 2018

[stable10] owncloud coding standard #31657

Closed

[stable10] owncloud coding standard #31722

Closed

PVince81 modified the milestones: development, QA Jun 13, 2018

phil-davis mentioned this pull request Jun 19, 2018

[stable10] owncloud coding standard #31828

Closed

This was referenced Jul 20, 2018

[stable10] owncloud coding standard #32103

Closed

[stable10] owncloud coding standard #32116

Merged

mmattel mentioned this pull request Nov 19, 2018

Developer Guide: php-cs-fixer owncloud/docs#295

Closed

2 tasks

lock bot locked as resolved and limited conversation to collaborators Jul 31, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

php-cs-fixer fix . --rules=native_function_invocation #31198

php-cs-fixer fix . --rules=native_function_invocation #31198

DeepDiver1975 commented Apr 19, 2018

codecov bot commented Apr 19, 2018 •

edited

Loading

mmattel commented Apr 20, 2018

mmattel commented Apr 20, 2018

DeepDiver1975 commented Apr 20, 2018

mmattel commented Apr 20, 2018

DeepDiver1975 commented Apr 20, 2018

mmattel commented Apr 20, 2018

butonic left a comment

butonic left a comment

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

butonic Apr 20, 2018

mmattel commented Apr 21, 2018

DeepDiver1975 commented Apr 21, 2018

patrickjahns commented Apr 21, 2018

phil-davis commented Apr 21, 2018

patrickjahns commented Apr 21, 2018 •

edited

Loading

phil-davis commented May 16, 2018

phil-davis commented May 16, 2018

lock bot commented Jul 31, 2019

php-cs-fixer fix . --rules=native_function_invocation #31198

php-cs-fixer fix . --rules=native_function_invocation #31198

Conversation

DeepDiver1975 commented Apr 19, 2018

Description

Motivation and Context

How Has This Been Tested?

Types of changes

Checklist:

codecov bot commented Apr 19, 2018 • edited Loading

Codecov Report

mmattel commented Apr 20, 2018

mmattel commented Apr 20, 2018

DeepDiver1975 commented Apr 20, 2018

mmattel commented Apr 20, 2018

DeepDiver1975 commented Apr 20, 2018

mmattel commented Apr 20, 2018

butonic left a comment

Choose a reason for hiding this comment

butonic left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mmattel commented Apr 21, 2018

DeepDiver1975 commented Apr 21, 2018

patrickjahns commented Apr 21, 2018

phil-davis commented Apr 21, 2018

patrickjahns commented Apr 21, 2018 • edited Loading

phil-davis commented May 16, 2018

phil-davis commented May 16, 2018

lock bot commented Jul 31, 2019

codecov bot commented Apr 19, 2018 •

edited

Loading

patrickjahns commented Apr 21, 2018 •

edited

Loading