Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude data from php style checks #31866

Merged
merged 1 commit into from
Jun 21, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jun 21, 2018

Description

Exclude the data folder from PHP code style checks

Related Issue

#31863

Motivation and Context

It is very annoying to report code style errors for code that is not part of the real core.

How Has This Been Tested?

  1. In a local dev environment, upload some crap PHP code to a test user account
  2. make test-php-style
  3. It fails on the crap code in the test user account
  4. checkout the branch with this change
  5. make test-php-style
  6. It passes

Types of changes

  • Bug fix (non-breaking change which fixes an issue) - to dev environnment
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@phil-davis phil-davis added this to the development milestone Jun 21, 2018
@phil-davis phil-davis self-assigned this Jun 21, 2018
@phil-davis
Copy link
Contributor Author

"backport" cherry-picked into #31828 which is waiting to implement the code-style checks in stable10

@codecov
Copy link

codecov bot commented Jun 21, 2018

Codecov Report

Merging #31866 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #31866   +/-   ##
=========================================
  Coverage     63.27%   63.27%           
  Complexity    18479    18479           
=========================================
  Files          1161     1161           
  Lines         69377    69377           
  Branches       1261     1261           
=========================================
  Hits          43895    43895           
  Misses        25112    25112           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.47% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.5% <ø> (ø) 18479 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7026417...ec31107. Read the comment docs.

@phil-davis phil-davis merged commit 848254a into master Jun 21, 2018
@phil-davis phil-davis deleted the exclude-data-from-php-style-checks branch June 21, 2018 16:20
@lock
Copy link

lock bot commented Jul 30, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants