Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Acceptance test steps for flexible share creation #32700

Closed
phil-davis opened this issue Sep 14, 2018 · 2 comments · Fixed by #33439
Closed

API Acceptance test steps for flexible share creation #32700

phil-davis opened this issue Sep 14, 2018 · 2 comments · Fixed by #33439
Assignees
Labels
Milestone

Comments

@phil-davis
Copy link
Contributor

PR #32699 added the ability to directly create a public link share with expiry date.
Existing test steps can create shares with various permissions.
It would also be useful to have:

  • steps for directly creating an ordinary share with expiry date
  • steps for more general creation of an ordinary and a public link share where you can specify a table of share attributes, so you can mix permissions, expiry date, share recipient etc.
@phil-davis phil-davis added this to the backlog milestone Sep 14, 2018
@phil-davis
Copy link
Contributor Author

Note: in Sharing.php we have userCreatesAShareWithSettings($user, $body)
That lets you specify a table of settings.
Its downside is that to get a public share you have to put in the table:

| shareType | 3           |

The "magic" numbers for share types make for test scenarios that are not so readable.

So, when sorting all this out, consider how to have steps that are a combination of "totally flexible" vs "readable".

@ownclouders
Copy link
Contributor

GitMate.io thinks the contributor most likely able to help you is @PVince81.

Possibly related issues are #22485 (test), #22492 (test), #31579 (test), #31516 (Acceptance test coding standard changes), and #31696 (Acceptance tests for exclude users from sharing changes).

@phil-davis phil-davis changed the title Acceptance test steps for flexible share creation API Acceptance test steps for flexible share creation Sep 24, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants