Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test steps to create a public share with an expiry date #32699

Merged
merged 1 commit into from
Sep 14, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 14, 2018

Description

Add acceptance test steps that allow "creates a share with expiry".
Implement the expireDate parameter in SharingHelper - for some reason nobody ever got around to doing this.

Motivation and Context

We need to be able to test creating a public share with an expiry date.

At the moment it has to be done in 2 steps, create the share then set the expiry date. So we cannot test fully the API endpoint that creates the share in the first place.

How Has This Been Tested?

Local runs of app acceptance tests that need to use this new step.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

phil-davis commented Sep 14, 2018

Note: there could also be:

  • steps for directly creating an ordinary share with expiry date
  • steps for more general creation of a ordinary and a public link share where you can specify a table of share attributes, so you can mix permissions, expiry date, share recipient etc.

But that is for the future see issue #3700

@phil-davis
Copy link
Contributor Author

Backport stable10 #32701

@DeepDiver1975 DeepDiver1975 merged commit 4c935dd into master Sep 14, 2018
@DeepDiver1975 DeepDiver1975 deleted the create-share-with-expiry branch September 14, 2018 06:54
@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants