Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow public link share default password to be passed to acceptance tests #32871

Closed
phil-davis opened this issue Sep 26, 2018 · 2 comments · Fixed by #32873
Closed

Allow public link share default password to be passed to acceptance tests #32871

phil-davis opened this issue Sep 26, 2018 · 2 comments · Fixed by #32873

Comments

@phil-davis
Copy link
Contributor

Currently the password used in public link share tests is hard-coded in each test scenario. We want to be able to run the tests against a system-under-test (SUT) that might have some password policy settings in place. We already made it possible to pass the admin password and user passwords in env variables to the acceptance tests. That allows the flexibility to pass password(s) that will work on the SUT.

Do similar for the password used for public link shares.

@phil-davis phil-davis added this to the development milestone Sep 26, 2018
@phil-davis phil-davis self-assigned this Sep 26, 2018
@phil-davis phil-davis changed the title Alllow public link share ddefault password to be passed to acceptance tests Allow public link share default password to be passed to acceptance tests Sep 26, 2018
@ownclouders
Copy link
Contributor

GitMate.io thinks possibly related issues are #31116 (Acceptance tests for lost password email), #32740 (Acceptance test steps for public link share), #32734 (Acceptance test steps for public link share), #5840 (sharing link with password), and #19632 (Forgotten Share Link Password).

@phil-davis
Copy link
Contributor Author

PR #32873 implements this.

@PVince81 PVince81 modified the milestones: development, QA Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants