Acceptance test steps for public link share #32734
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hide the magic link share numbers from the gherkin test code
Add steps to specifically create pubic link shares
Call them "public link share" rather than just "public share" or whatever else they were called.
Note: to-do some day, hide the magic for share type 0 (share with a user) and 1 (share with a group).
Motivation and Context
Acceptance test steps for shares have a lot of tests that mention
shareType
with "magic numbers" 0, 1, 3.Type 3 is a public link share. Hide this magic, and hopefully make the test steps more readable.
How Has This Been Tested?
CI
Types of changes
Checklist:
Open tasks: