Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance test steps for public link share #32734

Merged
merged 1 commit into from
Sep 18, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 17, 2018

Description

Hide the magic link share numbers from the gherkin test code
Add steps to specifically create pubic link shares
Call them "public link share" rather than just "public share" or whatever else they were called.

Note: to-do some day, hide the magic for share type 0 (share with a user) and 1 (share with a group).

Motivation and Context

Acceptance test steps for shares have a lot of tests that mention shareType with "magic numbers" 0, 1, 3.
Type 3 is a public link share. Hide this magic, and hopefully make the test steps more readable.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor Author

Backport stable10 #32740

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants