Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow public link share password to be overridden by PUBLIC_LINK_SHARE_PASSWORD #32873

Merged
merged 1 commit into from
Sep 27, 2018

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 26, 2018

Description

The public link share password can be inserted into steps that use it by putting %public%.

The default value is publicPwd1.

The default can be overridden by setting the env variable PUBLIC_LINK_SHARE_PASSWORD

Related Issue

Motivation and Context

Allow acceptance tests to use a flexible password when creating public link shares.

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis phil-davis force-pushed the public-link-share-test-password branch from 47f2ccd to d6e3265 Compare September 26, 2018 14:59
@codecov
Copy link

codecov bot commented Sep 27, 2018

Codecov Report

Merging #32873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #32873   +/-   ##
=========================================
  Coverage     64.12%   64.12%           
  Complexity    18684    18684           
=========================================
  Files          1177     1177           
  Lines         70309    70309           
  Branches       1270     1270           
=========================================
  Hits          45089    45089           
  Misses        24850    24850           
  Partials        370      370
Flag Coverage Δ Complexity Δ
#javascript 52.89% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 18684 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d2c509...d6e3265. Read the comment docs.

@phil-davis
Copy link
Contributor Author

Backport stable10 #32874

@phil-davis phil-davis merged commit 4552629 into master Sep 27, 2018
@phil-davis phil-davis deleted the public-link-share-test-password branch September 27, 2018 03:18
@lock lock bot locked as resolved and limited conversation to collaborators Sep 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow public link share default password to be passed to acceptance tests
2 participants