Add test scenarios for trying to reshare when user is in a group excluded from sharing

[phil-davis]

There are already some acceptance test scenarios that check that, for a user in a group that is excluded from sharing, that user cannot create a share of their own file or folder.
tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature

  Scenario: user tries to share a file in a group which is blacklisted from sharing
  Scenario: user tries to share a folder in a group which is blacklisted from sharing

• add scenarios to check that the user cannot reshare a share that they received from someone else, consider:
• reshare a single file received as a share Add tests to check re-share behavior inside blacklisted from sharing group #33865
• reshare a folder received as a share Add tests to check re-share behavior inside blacklisted from sharing group #33865
• reshare a file inside a folder received as a share Add tests to check re-share behavior inside blacklisted from sharing group #33865
• reshare a folder inside a folder received as a share Add tests to check re-share behavior inside blacklisted from sharing group #33865

None of these should be possible.

Ref: https://github.com/owncloud/enterprise/issues/3037

[ownclouders]

GitMate.io thinks possibly related issues are #33745 (Add tests for excluding group from receiving share), #10307 (Exclude Groups from Sharing), #17346 (Exclude group from sharing after a share was created), #31490 (Exclude users from sharing if they are a member of any excluded group), and #31696 (Acceptance tests for exclude users from sharing changes).

[paurakhsharma]

@phil-davis Turns out owncloud/enterprise#3037 is only UI bug where sharing dialog box shows field to enter the name of sharee. PR #33865 doesn't use UI to verify that. It only checks if the user is not allowed to share. New PR needs to be made to verify owncloud/enterprise#3037 where we should use UI to verify this.

[phil-davis]

Yes, the webUI is probably using its "private" API. The public sharing API is working, the new tests demonstrate that. I guess the private API used by the webUI will be not doing the needed checks.

[paurakhsharma]

@phil-davis Do we close this now?

[phil-davis]

Done - tests for attempting to reshare have been merged.

[phil-davis]

I raised issue #33918 to deal with the webUI issue.