Add tests to check re-share behavior inside blacklisted from sharing group #33865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paurakhsharma
requested review from
phil-davis,
individual-it,
skshetry and
dpakach
paurakhsharma
changed the title
phil-davis
reviewed
Dec 12, 2018
tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #33865 +/- ##
=========================================
Coverage 64.42% 64.42%
Complexity 18318 18318
=========================================
Files 1197 1197
Lines 69260 69260
Branches 1276 1276
=========================================
Hits 44621 44621
Misses 24267 24267
Partials 372 372
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #33865 +/- ##
=========================================
Coverage 64.76% 64.76%
Complexity 18330 18330
=========================================
Files 1198 1198
Lines 69382 69382
Branches 1276 1276
=========================================
Hits 44938 44938
Misses 24072 24072
Partials 372 372
Continue to review full report at Codecov.
|
paurakhsharma
force-pushed
the
webUI-test-excludeGroup-reshare
branch
from
70a177f
to
576142f
Compare
phil-davis
previously approved these changes
Dec 12, 2018
|
Backport on: #33866 |
skshetry
previously approved these changes
Dec 12, 2018
Closed
5 tasks
paurakhsharma
dismissed stale reviews from skshetry and phil-davis
I need to add more tests to check webUI
paurakhsharma
force-pushed
the
webUI-test-excludeGroup-reshare
branch
3 times, most recently
from
034104d
to
9de94be
Compare
skshetry
approved these changes
Dec 14, 2018
phil-davis
reviewed
Dec 14, 2018
tests/acceptance/features/bootstrap/WebUIAdminSharingSettingsContext.php
Outdated
Show resolved
Hide resolved
tests/acceptance/features/lib/FilesPageElement/SharingDialog.php
Outdated
Show resolved
Hide resolved
tests/acceptance/features/webUISharingInternalUsers/shareWithUsers.feature
Outdated
Show resolved
Hide resolved
paurakhsharma
force-pushed
the
webUI-test-excludeGroup-reshare
branch
from
9de94be
to
8f4915e
Compare
phil-davis
approved these changes
Dec 14, 2018
paurakhsharma
force-pushed
the
webUI-test-excludeGroup-reshare
branch
from
8f4915e
to
74721de
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR webUI tests for files_external delete local storage mount.
Related issue: #33824
How Has This Been Tested?
🤖
Types of changes
Checklist: