Support PHP 7.4

[phil-davis]

PHP 7.4 was released last week. It is now available in owncloud-ci/php:7.4

Enable support for PHP 7.4 in core.

• run CI with 7.4 (see WIP PR [Tests-Only] Php 7.4 fix phpunit #37280 )
• investigate and fix the fails that are reported
• think about other QA needed to be confident that core is ready for PHP 7.4 - regular release smoke tests should be enough
• sort out PHP 7.4 support for apps Run app acceptance tests with PHP 7.4 QA#645 phpunit 8 in app repos QA#647

[phil-davis]

PR #36500 gets various errors/warnings in phpunit and in some other test suites. So this is not a completely trivial job. Needs to be scheduled.

[phil-davis]

@micbar I am seeing developers mention PHP 7.4 more often - I think some people's Mac's etc have auto-updated to PHP 7.4... and they are trying to work with codebase...

What is the priority for getting this to happen (e.g. immediately that we get 10.4 release done?)

[jvillafanez]

• Need to update google API library for the implode order deprecation (https://github.com/owncloud/core/tree/master/apps/files_external/3rdparty/google-api-php-client)
• Some acceptance tests use implode with only one parameter. While this is fine, maybe we should keep consistency with the rest of the code. (Not a priority because it won't trigger any warning) - done in [Tests-Only] Explicitly specify empty glue in implode calls #37375

[Helios07]

This month' release of Fedora 32 will bring php7.4. Do you see the php7.4 support in 10.5 so that the upgrade will not leave a Fedora based owncloud server unusable?

[phil-davis]

• might need Guzzle6 (some code in [WIP] Guzzle6 for core #37011 - see my notes there)

there does not seem to be a problem with Guzzle5

[phil-davis]

For reference, these are PRs this week that adjusted unit tests and related to get PHP unit tests passing for PHP 7.4:
#37279
#37281
#37288
#37290
#37292
#37293
#37297
#37298
#37300

[micbar]

@phil-davis Can we close this?

[phil-davis]

@jvillafanez you made a couple of checklist items above. Are they still relevant?
If so, should we raise individual issues?

[jvillafanez]

There is a PR with the gdrive lib update that should be reviewed and merged.
The other check is just a small detail. We can ignore it for now and make the change on demand.

[phil-davis]

PR #37265 "Gdrive lib update"

[phil-davis]

PR #37265 has been merged.