Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Php 7.4 another pack of fixes #37293

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 22, 2020

Related Issue

owncloud/enterprise#3967

Motivation and Context

This is critical for unit tests to pass with PHP 7.4

How Has This Been Tested?

By CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo added this to the development milestone Apr 22, 2020
@VicDeo VicDeo self-assigned this Apr 22, 2020
@VicDeo VicDeo requested a review from phil-davis April 22, 2020 11:52
@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #37293 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37293   +/-   ##
=========================================
  Coverage     64.52%   64.52%           
- Complexity    19158    19161    +3     
=========================================
  Files          1266     1266           
  Lines         74925    74928    +3     
  Branches       1331     1331           
=========================================
+ Hits          48344    48347    +3     
  Misses        26189    26189           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.68% <100.00%> (+<0.01%) 19161.00 <0.00> (+3.00)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/File.php 83.92% <100.00%> (+0.05%) 116.00 <0.00> (+1.00)
...aring/lib/Controllers/ExternalSharesController.php 96.07% <100.00%> (+0.16%) 17.00 <0.00> (+2.00)
lib/private/Files/Storage/Wrapper/Encryption.php 69.19% <0.00%> (-0.25%) 158.00% <0.00%> (ø%)
apps/dav/lib/CardDAV/SyncService.php 46.36% <0.00%> (+0.90%) 25.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c19ff83...e4cc9fa. Read the comment docs.

@phil-davis phil-davis merged commit f448f56 into master Apr 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the php-7.4-fix-more-test2 branch April 22, 2020 12:51
@phil-davis phil-davis mentioned this pull request Apr 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants