Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests-Only] Php7.4 fix more tests vol 2 #37297

Merged
merged 2 commits into from
Apr 23, 2020
Merged

Conversation

VicDeo
Copy link
Member

@VicDeo VicDeo commented Apr 23, 2020

Description

  • be more explicit while checking if htaccess is a folder
  • check array keys existence before accessing them

Related Issue

https://github.com/owncloud/enterprise/issues/3967

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@VicDeo VicDeo added this to the development milestone Apr 23, 2020
@VicDeo VicDeo self-assigned this Apr 23, 2020
@VicDeo VicDeo requested a review from phil-davis April 23, 2020 07:52
@codecov
Copy link

codecov bot commented Apr 23, 2020

Codecov Report

Merging #37297 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37297   +/-   ##
=========================================
  Coverage     64.52%   64.52%           
- Complexity    19161    19165    +4     
=========================================
  Files          1266     1266           
  Lines         74928    74934    +6     
  Branches       1331     1331           
=========================================
+ Hits          48347    48353    +6     
  Misses        26189    26189           
  Partials        392      392           
Flag Coverage Δ Complexity Δ
#javascript 54.14% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.68% <100.00%> (+<0.01%) 19165.00 <0.00> (+4.00)
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 25.94% <100.00%> (+1.26%) 58.00 <0.00> (+1.00)
lib/private/Share/Share.php 71.05% <100.00%> (+0.03%) 504.00 <0.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f448f56...52a170d. Read the comment docs.

@phil-davis phil-davis merged commit 312ccc1 into master Apr 23, 2020
@delete-merged-branch delete-merged-branch bot deleted the php7.4-setup-n-share branch April 23, 2020 10:06
@phil-davis phil-davis mentioned this pull request Apr 24, 2020
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants