Extention of OCS to list the people/groups we can share with #13587
Conversation
|
Thanks a lot @rullzer - we will have a look at this as soon as we start with the dev cycle for 8.1. |
|
@DeepDiver1975 Yeah I figured that. I'll try to fix all the warnings that are autodetected here. Also I do not get why one of the unit tests fails since they work fine on my system. But I'll look into that this evening. |
well - most probably this is related to the environment like which users/groups exist and so on. Our current OCS code is not really ideal for unit testing. We are looking into alternatives for 8.1 - #12454 |
| @@ -596,4 +596,43 @@ private static function getShareFromId($shareID) { | |||
|
|
|||
| } | |||
|
|
|||
| public static function shareWith() { | |||
There was a problem hiding this comment.
the result set can be really hugh - which requires pagination - please add parameters like $limit and $offset
furthermore clients want to implement type ahead input fields which requires a $search parameter
There was a problem hiding this comment.
Ah yes that makes sense! It is added now. However now we still construct the entire array first on the server. So I will improve that later.
Also I need to look up how to test this.
|
Wow, is that somewhat a duplicate of the code used by the share dropdown ? |
|
@PVince81 yeah it is very similar. |
|
@PVince81 it should not be hard to extend this to also accept and output the current calls of the javascript calls. However I agree that should go into a different PR. |
|
I actually agree with this PR, will try and test it later this week. |
|
Great, then I'll start working on a patch to convert the ajax call to a call to the OCS API. |
|
Good luck with that. Hint: messy code. |
|
@rullzer can I ask you to squash your commits? THX |
|
@DeepDiver1975 squased and rebased |
|
@DeepDiver1975 @PVince81 @LukasReschke What is the state of this? Ready for review or is there more to add? |
|
I really want to get this (in one form or another) in 8.1 so I can implement user/group sharing in the client. I assume the code is "fine" since it is very similar to the ajax code (again the new modal should start using the same endpoint 😉 ). However what is left to discuss is the endpoint. Adding yet another endpoint here might not be the cleanest solution. Maybe we want something else like .../users and .../groups (somewhat related to #12454). That way at least this part of the API would be more rest like. And we would avoid more future hassel if we want to migrate. Comment/suggestions? I'll also squash my commits again and rebase to be sure I do not break anything in the current state. |
| } | ||
| } | ||
| if (array_key_exists('search', $_GET)) { | ||
| $search = $_GET['search']; |
There was a problem hiding this comment.
Please cast to (string) to prevent users from passing an array which potentially might result in havoc situations 🙈
* Simple API call to let the client(s) obtain a list of people we can share
files with.
* More or less the functionality the ajax call already provided but
then in a OCS call
* Filtering build in
* Pagination build in
* Added unit tests
|
The inspection completed: 4 updated code elements |
|
Refer to this link for build results (access rights to CI server needed): |
|
I moved this to 8.2 since I think it would be better to do it right in 1 go then to migrate away from it pretty soon already. |
|
Refer to this link for build results (access rights to CI server needed):
|
|
I'm closing tis PR in favor of the solution I'll be implenting for #16646 |
To allow the client to also do user/group sharing we need autocompletion on user and group names. Implementation is pretty straight forward, I directly wrote unit tests to ensure proper behaviour.