ajax/share.php should return correct list of suggestions

[rullzer]

Partial solves #8231

We should take advantage of the provided list of users and groups we already share with to filter the suggestions. This makes it harder to do double shares with the same users wich leads to bad UX.

Note to self: This should probably also be done in #13587

[scrutinizer-notifier]

The inspection completed: 2 new issues, 1 updated code elements

[ghost]

Refer to this link for build results (access rights to CI server needed):
https://ci.owncloud.org//job/pull-request-analyser-ng-simple/10815/
Test PASSed.

[jancborchardt]

Does this also help to fix #7128 by any chance? :)

[rullzer]

@jancborchardt I think for most situations yes.

[rullzer]

@jancborchardt after reading it a bit more careful, no it does not!

[jancborchardt]

Good stuff, fixes the second part of #8231 for me. 👍 Another review please @owncloud/designers?

[rullzer]

So, the other part is slightly harder. Since we currently do not fetch any data about the share. We should probably try to solve that while we try to fix #7128 et al.

[jancborchardt]

@rullzer do you want to do that in this PR or a separate one?

Another review please @owncloud/designers @schiesbn :)

[rullzer]

@jancborchardt that fix is far less trivial, so different PR.
I do however want to add some unit tests here. But that will not be tonight :)

[DeepDiver1975]

I do however want to add some unit tests here. But that will not be tonight :)

would be great to get this done these days - THX a lot!

[rullzer]

@DeepDiver1975 I think this code it not unit tested at all currently. So my ini tiny tests will not improve it much. And I do not really feel like adding unit tests for the whole file.

I suggest to just go forward and get rid of all the old ajax/*.php stuff before 8.2

[DeepDiver1975]

👍