Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the autocomplete blocker from #18341 into the OCS endpoint #18352

Merged
merged 2 commits into from
Sep 24, 2015
Merged

Implement the autocomplete blocker from #18341 into the OCS endpoint #18352

merged 2 commits into from
Sep 24, 2015

Conversation

nickvergessen
Copy link
Contributor

Replacing #18341

@nickvergessen nickvergessen added this to the 8.2-current milestone Aug 17, 2015
@nickvergessen
Copy link
Contributor Author

Only review the last commit here @DeepDiver1975 @MorrisJobke

@nickvergessen nickvergessen mentioned this pull request Aug 17, 2015
Merged
6 tasks
@MorrisJobke
Copy link
Contributor

Ömmm...I changed the config option to an appconfig implementation. Including options in the web UI

@MorrisJobke
Copy link
Contributor

accba48

@nickvergessen
Copy link
Contributor Author

@MorrisJobke cherry-picked

@nickvergessen nickvergessen force-pushed the ocs_api_sharees_autocomplete_blocker branch from 7f19c03 to 6c8017d Compare August 26, 2015 10:37
@scrutinizer-notifier
Copy link

A new inspection was created.

@rullzer
Copy link
Contributor

rullzer commented Sep 15, 2015

@nickvergessen could you rebase (since the shareeAPI is now merged)?. Seems like a good idea to respect the config variable.

@nickvergessen nickvergessen force-pushed the ocs_api_sharees_autocomplete_blocker branch from 6c8017d to 018f285 Compare September 15, 2015 07:17
@nickvergessen
Copy link
Contributor Author

Done

@rullzer
Copy link
Contributor

rullzer commented Sep 15, 2015

👍

@PVince81
Copy link
Contributor

Tested, works 👍

@PVince81
Copy link
Contributor

This is actually the forward port for #18353 which already exists on 8.1

@PVince81
Copy link
Contributor

@nickvergessen needs rebase

@nickvergessen nickvergessen force-pushed the ocs_api_sharees_autocomplete_blocker branch from 018f285 to 19e7a08 Compare September 23, 2015 13:11
@nickvergessen
Copy link
Contributor Author

rebased

@MorrisJobke
Copy link
Contributor

@DeepDiver1975 Can you merge once CI is fine? 😄

DeepDiver1975 added a commit that referenced this pull request Sep 24, 2015
@DeepDiver1975
Merge pull request #18352 from owncloud/ocs_api_sharees_autocomplete_…
8c0cf07 
…blocker

Implement the autocomplete blocker from #18341 into the OCS endpoint
@DeepDiver1975 DeepDiver1975 merged commit 8c0cf07 into master Sep 24, 2015
@DeepDiver1975 DeepDiver1975 deleted the ocs_api_sharees_autocomplete_blocker branch September 24, 2015 07:43
@nickvergessen nickvergessen mentioned this pull request Sep 24, 2015
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
3 - To Review blue-ticket feature:sharing Type:Bug
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
6 participants
@nickvergessen @MorrisJobke @scrutinizer-notifier @rullzer @PVince81 @DeepDiver1975