[stable8.1] Add option to disable autocomplete in share dialog #18353
Conversation
| @@ -379,6 +379,16 @@ | |||
| } | |||
| } | |||
|
|
|||
| $sharingAutocompletion = \OC::$server->getConfig() | |||
| ->getAppValue('core', 'shareapi_allow_share_dialog_user_enumeration', 'yes'); | |||
There was a problem hiding this comment.
app could be files_sharing? This is also where the OCS endpoint is going to live
There was a problem hiding this comment.
I think the reason it was "core" is because this setting would not only affect file sharing but also calendar, contact sharing
There was a problem hiding this comment.
I just used the same config option like all other sharing related options. Otherwise I need to write a lot more code to save this setting.
|
makes sense as a backport/stable solution 👍 |
|
🚀 Test PASSed.🚀 |
|
@nickvergessen @PVince81 Please review this |
|
👍 works |
[stable8.1] Add option to disable autocomplete in share dialog
|
cc @foobarable |
|
@cmonteroluque @nickvergessen Because #18236 was delayed to 9.0 we need to port this to master (8.2), right? |
|
Updated link, because it was the wrong paste |
|
That is what #18352 took care of |
Yes, but it is not used in the share drop down in 8.2 |
I just checked and it works in master. I just thought that the new code isn't used yet. Nevermind. It works. Thanks :) |
|
Well the PR added it to both, first commit was only your commit, second commit was "respect it in the OCS call" |
|
thanks @MorrisJobke |
The master version of this was closed, because the sharing dialog is reworked and should use the OCS API in the future. As this is too much stuff to backport, I ported the previous implementation of this to stable8.1.
@karlitschek Please approve this.
How to test
@Xenopathic Can you have a look at the wording of the Web UI config setting?
@nickvergessen @PVince81 @felixboehm Please have a look and review
cc @cdamken It was your request