Skip broken shares when transferring ownership #26527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @LukasReschke to be potential reviewers. |
This was referenced Nov 2, 2016
|
Integration tests will be added as part of #26543 |
|
@DeepDiver1975 @jvillafanez please review |
|
👍 |
| if ($shareMountPoint) { | ||
| $this->mountManager->removeMount($shareMountPoint->getMountPoint()); | ||
| } | ||
| $this->shareManager->deleteShare($share); |
There was a problem hiding this comment.
deleteShare throws ShareNotFound according to PHPDoc .... but I don't see this being throws in the implementation :puke:
This was referenced Nov 7, 2016
elie195
pushed a commit
to elie195/core
that referenced
this pull request
Mar 23, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Fixes #26524
Fixes #26525
Motivation and Context
Because aborting isn't useful as it would prevent legitimate subsequent shares to be migrated.
How Has This Been Tested?
See steps from the tickets
Screenshots (if appropriate):
Types of changes
Checklist:
Backports
@DeepDiver1975