Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transfer ownership integration tests #26543

Merged
merged 2 commits into from
Nov 7, 2016
Merged

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 3, 2016

This adds a new behat context for OCC commands and also for "files:transfer-ownership".

It's a bit tough because we need to mix Webdav + Sharing (later) for verification with the CommandLineContext. And mixing creates conflicts. This is getting really messy. At some point I think we should split the Webdav utility functions in separate traits maybe.

The last missing challenge for this PR to work correctly is making it possible to call regular Webdav assertions but using the generated transfer path. Maybe we should allow string substitutions in the given path:

	Then Downloaded content when downloading file "$lastTransferPath/somefile.txt" with range "bytes=0-6" should be "Welcome"

and have the code replace any $ variables found in such paths.

@owncloud/qa check this out

@PVince81 PVince81 added this to the 9.2 milestone Nov 3, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @nickvergessen to be potential reviewers.

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 4, 2016

Okay, I went with the route "replace the dav path with the last transferred folder" which makes all DAV operations relative to that one. Neat trick.

I've added a few more tests regarding sharing and external storage.

@SergioBertolinSG note for the future: now that this PR introduces a way to call OCC, it will be possible to create ext storages using these utility methods instead of in run.sh. Something for later.

Please review @SergioBertolinSG @davitol @DeepDiver1975

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 4, 2016

So, I decided to add more tests to cover some recent bugfixes. This means we cannot merge this PR until the following other PRs are merged:

@DeepDiver1975 DeepDiver1975 force-pushed the behat-transferownership branch from d143edc to a2e6663 Compare November 7, 2016 19:22
@DeepDiver1975
Copy link
Member

rebased - let's see

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 7, 2016

@DeepDiver1975 all passed, merge ? Or wait for @SergioBertolinSG to comment on my behat style next week when he's back ?

@DeepDiver1975 DeepDiver1975 merged commit 08ddae9 into master Nov 7, 2016
@DeepDiver1975 DeepDiver1975 deleted the behat-transferownership branch November 7, 2016 21:52
@PVince81
Copy link
Contributor Author

PVince81 commented Nov 8, 2016

Yay! Now we can even write tests for external storage config since we can access CLI ! 🎉

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 8, 2016

We should backport these to stable9.1 and stable9 but let's wait for the other matching backports to be merged first.

PVince81 pushed a commit that referenced this pull request Nov 11, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
PVince81 pushed a commit that referenced this pull request Nov 11, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
@PVince81
Copy link
Contributor Author

stable9.1: #26613
stable9: #26614

DeepDiver1975 pushed a commit that referenced this pull request Nov 14, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
DeepDiver1975 pushed a commit that referenced this pull request Nov 14, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
PVince81 pushed a commit that referenced this pull request Nov 18, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
DeepDiver1975 pushed a commit that referenced this pull request Nov 21, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
DeepDiver1975 added a commit that referenced this pull request Nov 21, 2016
…ship

[stable9.1] Add transfer ownership integration tests (#26543)
PVince81 pushed a commit that referenced this pull request Nov 24, 2016
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
DeepDiver1975 added a commit that referenced this pull request Nov 24, 2016
[stable9] Add transfer ownership integration tests (#26543)
elie195 pushed a commit to elie195/core that referenced this pull request Mar 23, 2017
* Add transfer ownership integration tests

* Added more transfer ownership tests and OCC checks
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants