-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add transfer ownership integration tests #26543
Conversation
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @DeepDiver1975 and @nickvergessen to be potential reviewers. |
9eeb0e6
to
36a72e8
Compare
Okay, I went with the route "replace the dav path with the last transferred folder" which makes all DAV operations relative to that one. Neat trick. I've added a few more tests regarding sharing and external storage. @SergioBertolinSG note for the future: now that this PR introduces a way to call OCC, it will be possible to create ext storages using these utility methods instead of in run.sh. Something for later. Please review @SergioBertolinSG @davitol @DeepDiver1975 |
So, I decided to add more tests to cover some recent bugfixes. This means we cannot merge this PR until the following other PRs are merged:
|
d143edc
to
a2e6663
Compare
rebased - let's see |
@DeepDiver1975 all passed, merge ? Or wait for @SergioBertolinSG to comment on my behat style next week when he's back ? |
Yay! Now we can even write tests for external storage config since we can access CLI ! 🎉 |
We should backport these to stable9.1 and stable9 but let's wait for the other matching backports to be merged first. |
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
…ship [stable9.1] Add transfer ownership integration tests (#26543)
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
[stable9] Add transfer ownership integration tests (#26543)
* Add transfer ownership integration tests * Added more transfer ownership tests and OCC checks
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This adds a new behat context for OCC commands and also for "files:transfer-ownership".
It's a bit tough because we need to mix Webdav + Sharing (later) for verification with the CommandLineContext. And mixing creates conflicts. This is getting really messy. At some point I think we should split the Webdav utility functions in separate traits maybe.
The last missing challenge for this PR to work correctly is making it possible to call regular Webdav assertions but using the generated transfer path. Maybe we should allow string substitutions in the given path:
and have the code replace any $ variables found in such paths.
@owncloud/qa check this out