Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transfer ownership now returns exit code on error #26546

Merged
merged 1 commit into from
Nov 7, 2016

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Nov 4, 2016

Description

Transfer ownership now returns exit code on error

Related Issue

No issue raised, but discovered while writing tests for #26543

Motivation and Context

Because we need a way to identify success from error

How Has This Been Tested?

  • invalid source user: ./occ files:transfer-ownership invalid_user existing_user => check exit code
  • invalid target user: ./occ files:transfer-ownership existing_user invalid_user => check exit code

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • x] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes => part of Add transfer ownership integration tests #26543
  • All new and existing tests passed.

Please review @davitol @PhilippSchaffrath @DeepDiver1975

@PVince81 PVince81 added this to the 9.2 milestone Nov 4, 2016
@mention-bot
Copy link

@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @nickvergessen and @LukasReschke to be potential reviewers.

@PVince81
Copy link
Contributor Author

PVince81 commented Nov 4, 2016

Integration tests will be added as part of #26543

@DeepDiver1975
Copy link
Member

👍

@DeepDiver1975 DeepDiver1975 merged commit 878ff03 into master Nov 7, 2016
@DeepDiver1975 DeepDiver1975 deleted the transfer-ownership-exitcodes branch November 7, 2016 12:22
elie195 pushed a commit to elie195/core that referenced this pull request Mar 23, 2017
@lock
Copy link

lock bot commented Aug 4, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants